Skip to content

NXT-18274: Fixed text controls in Storybook - #873

Merged
dan-ichim-lgp merged 1 commit into
developfrom
feature/NXT-18274
Aug 20, 2026
Merged

NXT-18274: Fixed text controls in Storybook#873
dan-ichim-lgp merged 1 commit into
developfrom
feature/NXT-18274

Conversation

@ion-andrusciac-lgp

@ion-andrusciac-lgp ion-andrusciac-lgp commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Fixed text controls in Storybook

Root cause: storybookjs/storybook#31091

Resolution

  • Created a patch for Storybook that allows saving in URL args text with special characters like ! ? '
  • Created a patch for Storybook that allows for saving the control value faster (the previous save interval was 1000ms, and now it is 100ms). This may prevent Boolean controls from flickering on some stories when the value is changed from true to false and vice versa
  • Added patch-package dependency that will apply the patch after install

Additional Considerations

  • Some of the stories that have a Marquee on render may take a while to update the control value
  • Added disableSaveFromUI to not show the popup to save the story after controls were edited for the dev environment that may block other controls
image

Links

NXT-18274

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.60%. Comparing base (daf0bd7) to head (577bcd5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #873   +/-   ##
========================================
  Coverage    85.60%   85.60%           
========================================
  Files          118      118           
  Lines         4495     4495           
  Branches      1226     1225    -1     
========================================
  Hits          3848     3848           
  Misses         503      503           
  Partials       144      144           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dan-ichim-lgp
dan-ichim-lgp merged commit e791446 into develop Aug 20, 2026
10 checks passed
@dan-ichim-lgp
dan-ichim-lgp deleted the feature/NXT-18274 branch August 20, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants