Repository navigation
Improve boot sequence. - #61
Merged
Merged
Conversation
ieQu1
force-pushed
the
dev/rl-barriers
branch
from
September 25, 2026 11:15
9c96f38 to
d182558
Compare
ieQu1
marked this pull request as ready for review
September 25, 2026 11:15
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Compilation, persistence compatibility, run-level validation, and boot API correctness issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (10)
What changed in this PR
Reworks boot sequencing around integer run levels and barriers, replacing classy_rl_changer.
Changes:
- Adds
classy_bootwith barrier-controlled transitions. - Updates hooks, votes, liveness, supervision, and tests.
- Adds public run-level constants and updates documentation.
| File | Description |
|---|---|
src/classy_boot.erl |
Implements boot and barrier management. |
src/classy_rl_changer.erl |
Removes the former run-level manager. |
src/classy.erl |
Exposes the revised run-level API. |
src/classy_node.erl |
Controls cluster and quorum barriers. |
src/classy_sup.erl |
Supervises the new boot manager. |
src/classy_hook.erl |
Registers new boot metadata hooks. |
src/classy_builtin_hooks.erl |
Emits enter/leave events. |
src/classy_liveness.erl |
Adopts enter/leave hook semantics. |
src/classy_lib.erl |
Adds quorum configuration access. |
src/classy_internal.hrl |
Defines run-level validation and events. |
include/classy.hrl |
Includes public run-level constants. |
include/classy_rl.hrl |
Defines numeric run levels. |
src/classy_vote.erl |
Adapts vote scheduling to ranges. |
src/classy_vote.hrl |
Updates persisted run-level typing. |
src/classy_vote_coordinator.erl |
Updates coordinator restoration types. |
src/classy_vote_participant.erl |
Uses the new boot state. |
src/test/classy_ct.erl |
Updates run-level test hooks. |
src/test/classy_test_fuzzer.erl |
Updates synchronization and diagnostics. |
test/classy_SUITE.erl |
Tests barriers and revised transitions. |
doc/classy.texi |
Documents the quorum default. |
rebar.config |
Updates Meck to 1.2.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+767
to
+769
| to_stopped(Reason, _Timeout) -> % FIXME | ||
| prep_stop(Reason), | ||
| classy_rl_changer:set_sync(?stopped, Timeout). | ||
| classy_boot:stop_system(). |
Comment on lines
456
to
+457
| verify_run_level(#{}) -> | ||
| {ok, classy_rl_changer:to_int(?cluster)}. | ||
| {ok, ?classy_rl_cluster}. |
ieQu1
force-pushed
the
dev/rl-barriers
branch
from
September 25, 2026 13:21
d182558 to
3fef13c
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Boot-stage barriers, compilation, persisted-vote compatibility, and bounded shutdown contain unresolved correctness issues.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (10)
Resolved since last review (7)
ieQu1
force-pushed
the
dev/rl-barriers
branch
from
September 30, 2026 12:41
1a5970d to
1d3396f
Compare
ieQu1
force-pushed
the
dev/rl-barriers
branch
from
September 30, 2026 12:48
1d3396f to
027ac8c
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Synchronous barriers can crash the boot manager, and shutdown can deadlock while a hook calls it.
Review effort: Balanced
Findings: 2
Open (9)
Resolved since last review (7)
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved readiness, shutdown, diagnostics, and persisted-vote compatibility defects affect boot correctness.
Review effort: Balanced
Findings: 5
Open (7)
Resolved since last review (7)
| classy_table:flush(?tab), | ||
| classy_table:flush(?site_info), | ||
| to_stopped(shutdown, infinity), | ||
| to_stopped(shutdown), |
Comment on lines
+98
to
+102
| classy_boot:with_ready( | ||
| RunLevel, | ||
| fun() -> | ||
| classy_sup:ensure_vote_coordinator([true, {ID, Options}]) | ||
| end). |
Member
Author
There was a problem hiding this comment.
This is accepted for now, see comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #27
Completely rework the run level concept.