feat: SilentMessageEventHandler - #162
Conversation
Control PanelHi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
|
SummaryThe following content is AI-generated and provides a summary of the pull request: Add
|
There was a problem hiding this comment.
The PR introduces silent push notification handling via a HeadlessJsTaskService on Android and an EventEmitter on iOS. While the overall architecture is sound, there are several correctness issues that should be addressed before merging: an inverted/misleading boolean parameter controlling the two handler modes, a missing wake lock acquisition for the Android headless service, potential duplicate event deliveries on iOS due to untracked subscriptions, and a JSONObject.put(key, null) edge case that may silently drop the payload field from the JS task data.
PR Bot Information
Version: 1.31.9
- Event Trigger:
issue_comment.edited - Correlation ID:
a88b3470-a755-11f1-8d25-9c7ebd29665e - File Content Strategy: Full file content
- LLM:
anthropic--claude-4.6-sonnet
b0b35d1 to
cfe1705
Compare
There was a problem hiding this comment.
The iOS EventUtils.m crash on nil payload is in the unchanged portion of the file (not in the diff), so it can't be commented on directly. The RNEmarsys.kt setup() file is also not part of the diff. Only one new comment was successfully posted.
The PR introduces the setSilentMessageEventHandler feature with reasonable structure, but has several issues raised across this and prior review rounds — most notably the unconditional NativeEmarsys.setSilentMessageEventHandler() call outside the platform guard (now flagged), plus the previously flagged wake lock, payload null handling, and duplicate listener concerns that should be addressed before merging.
PR Bot Information
Version: 1.31.9
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
5642ba70-a797-11f1-8698-4b02017df260 - Event Trigger:
issue_comment.created - File Content Strategy: Full file content
cfe1705 to
ee138a7
Compare
MV-1188