Repository navigation
Remove dead autolink_spec(nil, _opts) - #2275
Merged
Merged
Conversation
In f40c272, `ExDoc.Language.Erlang` introduced `typespec(nil, _opts)`, which violated the callback typespec (`@callback typespec(...) :: iodata()`). No callers actually passed `nil`. In 563f79c, `typespec/2` was renamed to `autolink_spec/2` and this nil clause was carried over verbatim. It has been dead code violating the callback contract since its introduction. Assisted-by: Antigravity:Gemini 3.8 Flash
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/38234926930/artifacts/11740098033 |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the dead code while working on #2274.
In f40c272,
ExDoc.Language.Erlangintroducedtypespec(nil, _opts), which violated the callback typespec (@callback typespec(...) :: iodata()). No callers actually passednil.In 563f79c,
typespec/2was renamed toautolink_spec/2and this nil clause was carried over verbatim.It has been dead code violating the callback contract since its introduction.