Skip to content

Remove numlockx dependency - #899

Closed
atharvafulay wants to merge 1 commit into
elementary:mainfrom
atharvafulay:agent/remove-numlockx
Closed

Remove numlockx dependency#899
atharvafulay wants to merge 1 commit into
elementary:mainfrom
atharvafulay:agent/remove-numlockx

Conversation

@atharvafulay

Copy link
Copy Markdown

Summary

  • remove the X11-only numlockx startup invocation
  • remove the now-unused activate_numlock setting
  • remove the obsolete sample configuration key
  • leave the Num Lock state indicator unchanged

Why

numlockx only operates on X11. Keeping the external process invocation in the greeter leaves a dead and misleading configuration path as the project moves through its Wayland-capable startup flow. Removing the complete integration fixes the dependency at its source instead of suppressing spawn errors.

Fixes #898.

Validation

  • git diff --check
  • verified there are no remaining numlockx, activate_numlock, or activate-numlock references under src/ or data/
  • meson setup build reached dependency resolution, then stopped because Homebrew does not provide a supported wayland-scanner bottle on this macOS host; the Linux CI build is required for full compilation

AI disclosure

OpenAI Codex assisted with repository research, the focused edit, and validation. I reviewed the final diff before publishing.

@danirabbit

Copy link
Copy Markdown
Member

Sorry, AI contributors are not allowed under our contributor guide https://docs.elementary.io/contributor-guide/development/generative-ai-policy

@atharvafulay
atharvafulay marked this pull request as ready for review July 28, 2026 16:19
@danirabbit danirabbit closed this Jul 28, 2026
@atharvafulay
atharvafulay deleted the agent/remove-numlockx branch July 28, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove numlockx dependency

2 participants