Remove numlockx dependency - #899
Closed
atharvafulay wants to merge 1 commit into
Closed
Conversation
Member
|
Sorry, AI contributors are not allowed under our contributor guide https://docs.elementary.io/contributor-guide/development/generative-ai-policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numlockxstartup invocationactivate_numlocksettingWhy
numlockxonly operates on X11. Keeping the external process invocation in the greeter leaves a dead and misleading configuration path as the project moves through its Wayland-capable startup flow. Removing the complete integration fixes the dependency at its source instead of suppressing spawn errors.Fixes #898.
Validation
git diff --checknumlockx,activate_numlock, oractivate-numlockreferences undersrc/ordata/meson setup buildreached dependency resolution, then stopped because Homebrew does not provide a supportedwayland-scannerbottle on this macOS host; the Linux CI build is required for full compilationAI disclosure
OpenAI Codex assisted with repository research, the focused edit, and validation. I reviewed the final diff before publishing.