Memory hog: Update checks never release memory to the system - #2438
Open
lewisgoddard wants to merge 1 commit into
Open
Memory hog: Update checks never release memory to the system#2438lewisgoddard wants to merge 1 commit into
lewisgoddard wants to merge 1 commit into
Conversation
…ates Each change to a flatpak installation fires many FileMonitor events, and every event queued a full reload of both AppStream pools. With no debounce and no re-entrancy guard, routine flatpak activity stacked reloads whose large transient allocations ratcheted RSS to a multi-hundred-MB high-water that glibc never returned, so an idle --silent daemon sat near a gigabyte. Coalesce the monitor events into a single refresh once activity settles, guard trigger_update_check so refreshes cannot stack, and malloc_trim() after each update check to hand the freed transients back to the OS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
malloc_trim()after each update check to hand the free'd memory back to the OS.Free's ~500MiB outside of update checks.