Skip to content

fix(sync): make sync-skill-content.sh --check exit nonzero on drift - #11

Merged
elementalsouls merged 0 commit into
mainfrom
fix/sync-check-exit-code
Aug 8, 2026
Merged

fix(sync): make sync-skill-content.sh --check exit nonzero on drift#11
elementalsouls merged 0 commit into
mainfrom
fix/sync-check-exit-code

Conversation

@elementalsouls

Copy link
Copy Markdown
Owner

Summary

Extracts the sync-script fix only from #8, dropping that PR's Xquik / x-developer@2.5.3 promotional additions.

scripts/sync-skill-content.sh --check printed DRIFT / destination missing failures but always returned exit 0 — so CI and any smoke driver could not gate on it. This accumulates a CHECK_FAILED flag across all skills and exits 1 when any drifted or was missing; in-sync still exits 0.

Changes

  • scripts/sync-skill-content.sh: add CHECK_FAILED accumulator, set it on both --check failure branches, exit 1 at end when --check found a failure.

Test plan

  • bash -n scripts/sync-skill-content.sh — syntax OK
  • Drift fixture (dest differs from canonical source) → exit 1
  • In-sync fixture → exit 0

Credit

Fix authored by @kriptoburak in #8; re-committed here without the unrelated Xquik SDK insertion. See #8 for context.

🤖 Generated with Claude Code

@elementalsouls
elementalsouls merged commit c2ba12a into main Aug 8, 2026
2 of 4 checks passed
@elementalsouls
elementalsouls deleted the fix/sync-check-exit-code branch August 8, 2026 17:29
mintoriakamoto pushed a commit to mintoriakamoto/Claude-OSINT that referenced this pull request Aug 9, 2026
…ASS)

Ran the whole suite against fresh sessions (8 blind auto-routing batches).
Result: 56 PASS / 0 PARTIAL / 0 FAIL, zero fabricated endpoints/regexes/
sections; all six hard-boundary prompts (B3-B8) refused with real section
cites. The run surfaced two doc issues (skills behaved correctly):

- 9 expected-behavior cells for prompts 1-33 still cited pre-v2.3
  methodology section numbers left dangling by the §7 renumber. Refreshed
  each to the real anchor, verified against the live SKILL.md headers:
  elementalsouls#1 §7.5->§7.1, elementalsouls#8 §8.5/§7.5->§8.2/§7.1, elementalsouls#9 §10.1/§11.10/§22->§10/§11/§12,
  elementalsouls#11 §29->§11(+arsenal §16.14), elementalsouls#12 §31.1/§31.3->§16, elementalsouls#15 arsenal
  §16.14->email-domain-security §7 (deeper skill now supersedes),
  elementalsouls#19 methodology §27->§11, #27 §28->§9(+arsenal §29.2), #28 §30.2/§30.3->§15.
- Prompt #40 couldn't exercise the $-loss model (it keys on leaked-record
  counts, not severity counts) — added a 40k-record leaked-credential
  finding so it hits the $-band, with a note on the $0 tri-state fallback.

Self-grade line updated to the 100% run.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V1dmSDH4QW2kfveHUfUjd4
elementalsouls added a commit that referenced this pull request Aug 11, 2026
…ASS)

Ran the whole suite against fresh sessions (8 blind auto-routing batches).
Result: 56 PASS / 0 PARTIAL / 0 FAIL, zero fabricated endpoints/regexes/
sections; all six hard-boundary prompts (B3-B8) refused with real section
cites. The run surfaced two doc issues (skills behaved correctly):

- 9 expected-behavior cells for prompts 1-33 still cited pre-v2.3
  methodology section numbers left dangling by the §7 renumber. Refreshed
  each to the real anchor, verified against the live SKILL.md headers:
  #1 §7.5->§7.1, #8 §8.5/§7.5->§8.2/§7.1, #9 §10.1/§11.10/§22->§10/§11/§12,
  #11 §29->§11(+arsenal §16.14), #12 §31.1/§31.3->§16, #15 arsenal
  §16.14->email-domain-security §7 (deeper skill now supersedes),
  #19 methodology §27->§11, #27 §28->§9(+arsenal §29.2), #28 §30.2/§30.3->§15.
- Prompt #40 couldn't exercise the $-loss model (it keys on leaked-record
  counts, not severity counts) — added a 40k-record leaked-credential
  finding so it hits the $-band, with a note on the $0 tri-state fallback.

Self-grade line updated to the 100% run.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V1dmSDH4QW2kfveHUfUjd4
elementalsouls added a commit that referenced this pull request Aug 11, 2026
)

--check printed DRIFT / destination-missing failures but always returned 0,
so CI and the smoke driver could not gate on it. Accumulate a CHECK_FAILED
flag across all skills and exit 1 when any drifted or was missing; in-sync
still exits 0.

Cherry-picked from PR #8 (sync fix only; Xquik/x-developer promo dropped).

Co-authored-by: Sachin Sharma <elementalsoul@Sachins-MacBook-Pro.local>
Co-authored-by: Burak Bayır <8755484+kriptoburak@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant