Add excludes capability

[hartfordfive]

Adding the exclude feature as requested in issue #89.

[driskell]

Rather than exclude paths as a parameter maybe p.FileConfig here?

It saves the parameter list from growing :)

[driskell]

👍 Looks good I just did a tiny review to help out :)

[hartfordfive]

@driskell, thanks pointing out those small improvements that can be made. I'll fix those by tomorrow and commit the changes.

[jordansissel]

code looks good. can you add tests, please?

[hartfordfive]

I take it you mean add the tests to the config_test.go file?

[jordansissel]

Tests to verify that when it is configured to exclude files it behaves
correctly. Where the test lives is less important than what it tests.

I am in my phone so I can't offer specific advice on where to put the test
right now.

On Thursday, February 12, 2015, Al Lefebvre notifications@github.com
wrote:

I take it you mean add the tests to the config_test.go file?

—
Reply to this email directly or view it on GitHub
#342 (comment)
.

[hartfordfive]

I apologize for the delay on this, I just haven't had the chance lately to work on this. I'll do my best figure out an appropriate testing mechanism and push it to this branch asap.

[hartfordfive]

@jordansissel I've created a test suite (in the "test_vm/" directory) using test kitchen along with the shell provisioner. This test seems to do the job just fine although let me know if you have any questions or comments about it.

[webmat]

The directory test_excludes should probably be deleted now.

The tests work for me. Although I need to look at bootstrap.sh carefully to understand which log files are ignored vs those that are consumed.

Perhaps you could make their names more obvious? E.g. /var/log/excluded1.log and /var/log/consumed1.log

[hartfordfive]

@driskell and @jordansissel do you have any feedback about the tests I created for this feature? I figured this could also potentially be used for any other tests in the future, seeing it's self contained VM that provisions itself.

[hartfordfive]

Any updates on this issue? Is there any chance you'll be merging this feature and the tests back into the master branch?