docs: clarify dictionary method keys - #654
Open
janmarsino98 wants to merge 1 commit into
Open
Conversation
janmarsino98
marked this pull request as ready for review
July 14, 2026 13:01
JackSpiece
approved these changes
Jul 30, 2026
JackSpiece
left a comment
There was a problem hiding this comment.
Verified this against the behavior reported in #496 with temporary DOCX templates. {{ soil.pop }} resolves to the dictionary method, autoescape=True renders that method representation as text rather than selecting the key, and {{ soil['pop'] }} renders 2 as intended. Without autoescaping, the method representation is interpreted as XML and the visible value is lost.
I also ran the exact project flake8 command, git diff --check, and a Sphinx dummy build with warnings treated as errors. All passed. This documents the workaround the owner requested and the placement is appropriate. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
{{ soil.pop }}resolves to the dictionary method rather than thepopcontext key.{{ soil['pop'] }}renders the intended value.Fixes #496
Validation
git diff --check{{ soil['pop'] }}and confirmed that it reopens with the expected value.