feat: refactor register-map#337
Open
HelenaSabel wants to merge 1 commit into
Open
Conversation
…and accessible from the odd
wolfgangmm
reviewed
May 14, 2026
| [% endif %] | ||
|
|
||
| [% if map:contains($defaults, "register-map") %] | ||
| declare variable $config:register-map as map(*) := parse-json('[[$defaults?register-map]]'); |
Member
There was a problem hiding this comment.
We should not need parse-json here. And because this is a feature specific to the register profile, the setting should probably go into features.register, not defaults.
wolfgangmm
reviewed
May 14, 2026
|
|
||
| [% if map:contains($defaults, "register-map") %] | ||
| declare variable $config:register-map as map(*) := parse-json('[[$defaults?register-map]]'); | ||
| [% else %] |
Member
There was a problem hiding this comment.
You don't need else here. The default should be in the profiles/register/config.json. This way, you'll also benefit from object merging when extending the profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
$config:register-mapto the defaults ofconfig.json(and makes the pertinent changes in the schema)odd-globalso that it can be accessed from the ODD (before, the IDs to the registers were hard-coded in the TEI Publisher ODD)