Skip to content

IAV_Primula: "Hello World" for IAV_Primula - #77

Merged
masc2023 merged 11 commits into
eclipse-score:mainfrom
iavofficial:main
Jul 15, 2026
Merged

IAV_Primula: "Hello World" for IAV_Primula#77
masc2023 merged 11 commits into
eclipse-score:mainfrom
iavofficial:main

Conversation

@HeHa112

@HeHa112 HeHa112 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

PR for Task #52.

Motivation

First step for IAV_Primula in the inc_security_crypto repo.

Changes

Adapt the component template for IAV_Primula integration.

Behaviour

External behavior not available.

Testing

  • First "Hello World" test is added
  • All necessary GitHub Actions are integrated and passed

Scope

Check that the component template has been implemented correctly.

HeHa112 and others added 2 commits July 7, 2026 09:02
* Added component template for IAV_Primula

* Add "Hello World"

* test fix

* renamed lib to main

* Changed documentation part from template to IAV_Primula

* Add gitattributes for LF in iav_primula Rust files

* Enforce LF for iav_primula BUILD file to satisfy buildifier

* Format iav_primula test BUILD for buildifier

* copyright header changed

* Update BUILD in tests

---------

Co-authored-by: cpelka <carolina.pelka@iav.de>
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: f3f53631-9888-42bc-9aa1-9d939aa1cbbb
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'abseil-cpp+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-m3oGQwXp/ZTRJP+mzDWFkutCtdpYj7TgfQklSqQAhts="
DEBUG: Repository abseil-cpp+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'grpc+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-CvN7gAlTEwtHwHW1ZoPuYL3D7aPDf8YAQZP1tWl1ggQ="
DEBUG: Repository grpc+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
DEBUG: Rule 'protobuf+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-w6Cp7OiTLjHDtzbi2xixxC5wcM2biBOIsm0BqnHiTKI="
DEBUG: Repository protobuf+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
INFO: Elapsed time: 8.419s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@HeHa112
HeHa112 marked this pull request as ready for review July 8, 2026 09:59

@sunildevda sunildevda left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor findings from my side

:id: doc__iav_primula_arc_inspection
:status: draft
:safety: QM
:security: NO

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be YES as all this is security relevant.

same point applies to all other places.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I’ll fix it.

Functional Requirements
-----------------------

.. comp_req:: Provide hello message function

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this requirement? hello world is just a dummy first implementation, so IMHO we dont need to write this as a requirement. or other option is to remember to remove it when the hello world implementation is removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this requirement so that we can get familiar with the tool environment. If the "Hello World" function is removed, I will remove the requirement as well.

@HeHa112

HeHa112 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

some minor findings from my side

@sunildevda: Thanks for the review. I’ll have a look at it.

@HeHa112 HeHa112 closed this Jul 9, 2026
@HeHa112 HeHa112 reopened this Jul 9, 2026
@sunildevda
sunildevda requested a review from ChansAlive July 10, 2026 11:48

@sunildevda sunildevda left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good to me.

@ChansAlive
ChansAlive removed their request for review July 14, 2026 14:20
@sunildevda
sunildevda requested a review from masc2023 July 15, 2026 08:19
@masc2023
masc2023 merged commit 7315f81 into eclipse-score:main Jul 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants