Skip to content

crypto: Add qnx test execution for test binaries (cc_test) - #70

Merged
PandaeDo merged 2 commits into
eclipse-score:mainfrom
etas-contrib:add_qnx_test_support
Jul 16, 2026
Merged

crypto: Add qnx test execution for test binaries (cc_test)#70
PandaeDo merged 2 commits into
eclipse-score:mainfrom
etas-contrib:add_qnx_test_support

Conversation

@OliverHeilwagen

@OliverHeilwagen OliverHeilwagen commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

resolves #13

  • Update used toolchain version and add rules_imagefs for qnx images.
  • Update bazel dependencies to remove warnings.
  • Update devcontainer to support local execution.
  • Rename existing test workflow to test_linux.
  • Add test workflow for qnx.
  • Fix incorrect destruction orders identified by testing on qnx.

@github-actions

github-actions Bot commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 7edd6c40-edcf-48c3-9d11-e08837b145e9
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'abseil-cpp+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-m3oGQwXp/ZTRJP+mzDWFkutCtdpYj7TgfQklSqQAhts="
DEBUG: Repository abseil-cpp+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'grpc+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-CvN7gAlTEwtHwHW1ZoPuYL3D7aPDf8YAQZP1tWl1ggQ="
DEBUG: Repository grpc+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'protobuf+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-w6Cp7OiTLjHDtzbi2xixxC5wcM2biBOIsm0BqnHiTKI="
DEBUG: Repository protobuf+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
INFO: Elapsed time: 12.818s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@OliverHeilwagen OliverHeilwagen self-assigned this Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

OliverHeilwagen
OliverHeilwagen commented Jul 3, 2026
View reviewed changes
Comment thread qnx_unit_tests.patch Outdated
@sunildevda
sunildevda requested review from PandaeDo and se-lo July 3, 2026 11:29
@OliverHeilwagen
OliverHeilwagen force-pushed the add_qnx_test_support branch 4 times, most recently from 54803a0 to 916ddc8 Compare July 7, 2026 12:24
OliverHeilwagen
OliverHeilwagen commented Jul 7, 2026
View reviewed changes
Comment thread .devcontainer/devcontainer-lock.json Outdated
@OliverHeilwagen
OliverHeilwagen force-pushed the add_qnx_test_support branch 2 times, most recently from 591067a to a92eebf Compare July 8, 2026 07:57
se-lo
se-lo reviewed Jul 9, 2026
View reviewed changes

@se-lo se-lo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor findings / clarification.

Comment thread .devcontainer/devcontainer.json
Comment thread .github/tools/qnx_credential_helper.py
Comment thread .github/workflows/test_qnx.yml Outdated
Comment thread .github/workflows/test_qnx.yml
Comment thread tests/key_management/test_key_management_context.cpp Outdated
Comment thread README.md Outdated
@OliverHeilwagen
OliverHeilwagen force-pushed the add_qnx_test_support branch 2 times, most recently from 6960fca to d6fce8d Compare July 10, 2026 07:15
se-lo
se-lo approved these changes Jul 10, 2026
View reviewed changes

@se-lo se-lo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Actual QNX pipeline run pending (QNX secrets not yet available).

@OliverHeilwagen
crypto: Add qnx test execution for test binaries (cc_test)
ea8c41d 
- Update used toolchain version and add rules_imagefs for
  qnx images.
- Update bazel dependencies to remove warnings.
- Update devcontainer to support local execution.
- Rename existing test workflow to test_linux.
- Add test workflow for qnx.
- Fix incorrect destruction orders identified by testing
  on qnx.
@OliverHeilwagen
crypto: Fix findings for qnx test execution (cc_test)
348d445
@PandaeDo
PandaeDo merged commit 72ea63f into eclipse-score:main Jul 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PandaeDo PandaeDo PandaeDo approved these changes
+1 more reviewer
@se-lo se-lo se-lo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@OliverHeilwagen OliverHeilwagen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test on QNX8 (local tests)

3 participants

@OliverHeilwagen @PandaeDo @se-lo