bump tooling repo + small fixes#619
Open
hoe-jo wants to merge 9 commits into
Open
Conversation
hoe-jo
commented
Jun 30, 2026
hoe-jo
commented
Contributor
- Bump Tooling Repo to include new rendering of safety analysis
- Add Toolchain for Libclang
- Adapt TRLC Tracing for Guidewords
- Fix rendering of SafetyAnalysis in Communication Repo
- Small fixes for Safety Analysis for MW::COM renaming only
hoe-jo
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11 and
limdor
as code owners
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| if _fta_metamodel_dir | ||
| else "" | ||
| ) | ||
| plantuml = f"{_plantuml_path}{_include_flag} -Playout=smetana" |
hoe-jo
force-pushed
the
joho_bump_tooling_repo
branch
4 times, most recently
from
3e8f485 to
0f0f264
Compare
hoe-jo
force-pushed
the
joho_bump_tooling_repo
branch
from
0f0f264 to
4210c36
Compare
castler
requested changes
Jul 2, 2026
| targets = ["linux-aarch64"], | ||
| ) | ||
| use_repo(llvm, "llvm_toolchain") | ||
| use_repo(llvm, "llvm_toolchain", "llvm_toolchain_llvm") |
Contributor
There was a problem hiding this comment.
Why do you add here a new name? why do you not just reference it by llvm_toolchain?
Contributor
Author
There was a problem hiding this comment.
llvm_toolchain_llvm is required for libclang, its not included in llvm_toolchain
| cxx_builtin_include = "@llvm_toolchain_llvm//:cxx_builtin_include", | ||
| extra_config_site = "@llvm_toolchain_llvm//:extra_config_site", | ||
| libclang = "@llvm_toolchain_llvm//:lib/libclang.so", | ||
| visibility = ["//visibility:public"], |
| name = "score_communication_libclang_toolchain", | ||
| toolchain = ":score_communication_libclang", | ||
| toolchain_type = "@score_tooling//cpp/libclang:libclang_toolchain_type", | ||
| visibility = ["//visibility:public"], |
| maturity = "development", | ||
| requirements = [], | ||
| tests = [], | ||
| visibility = ["//visibility:public"], |
Contributor
There was a problem hiding this comment.
Why public visiblity?
We should make a macro do avoid this copy n paste for external modules.
hoe-jo
force-pushed
the
joho_bump_tooling_repo
branch
from
4210c36 to
81f79b8
Compare
hoe-jo
force-pushed
the
joho_bump_tooling_repo
branch
from
81f79b8 to
6b50c27
Compare
castler
approved these changes
Jul 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.