fix: consolidating deletion logic in ExtensionService#1935
Open
gnugomez wants to merge 3 commits into
Open
Conversation
gnugomez
force-pushed
the
gnugomez/main/delete-extensions-consolidation
branch
from
f2be33b to
26a8425
Compare
autumnfound
approved these changes
Jul 3, 2026
autumnfound
left a comment
autumnfound
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, but I haven't run the server locally to do a full test.
Assisted-By: anthropic:claude-opus-4-8[1m]
netomi
force-pushed
the
gnugomez/main/delete-extensions-consolidation
branch
from
26a8425 to
e919387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a followup of #1919, while consolidating the deletion logic, the race condition has also been fixed in the admin dashboard extension deletion flow.
I'm also adding the corresponding front-end changes to re-fetch the data if the error status equals to 409.