Repository navigation
feat: Suggest worktrees made outside HomeShell as workstreams #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5,190
−482
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
45fc498
feat(daemon): suggest untracked worktrees, and retire worktrees gone
planger ced1a46
feat(ui): untracked worktrees in the project view
planger a1dedd4
test(e2e): untracked worktrees over the API and in the project view
planger c3725dc
test(web): wait for the new workstream form to take focus
planger e5ee223
fix(ui): untracked worktrees keep the list's one tab stop
planger dd4f707
fix(ui): an untracked worktree named after its branch shows it once
planger 11135f2
refactor(ui): one rule for the untracked worktrees' tab stop
planger d6e2699
fix(ui): an untracked worktree's copy button keeps the one tab stop too
planger e0f7bac
fix(daemon): a suggestion counts its sessions by the ended rule
planger dd9128f
feat: a vanished worktree's sessions are never stopped on their own
planger dfc6ba8
test(daemon): changes made during a surveyed pass win, and a tracked …
planger 35f301c
fix(daemon): a pass's folder mark survives a change made meanwhile, a…
planger aa76c26
refactor(daemon): one session index for the store, and the resurvey c…
planger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sessions on a suggestion never reach a client, and notify only walks
project.Workstreams(notify.go), so an agent waiting for input in an external worktree now goes silent, where before this PR its adopted workstream showed and notified it. On upgrade an existing adopted workstream in such a folder is dropped too, so a maintainer should confirm that trading visibility for "never add on its own" is intended. If it is,sessionCountshould at least flag a waiting session.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! This is handled in #8.