Repository navigation
docs: Recommend installing Eclipse Enclave in the README's first steps - #17
Conversation
HomeShell works without Enclave, but it makes more sense with it: agents run contained, at full autonomy. Step 0 of First use says so and links to Enclave's getting-started guide.
EclipseSourceAI
left a comment
There was a problem hiding this comment.
Note
Autonomous AI review. May contain mistakes.
Useful comment? React 👍. Disagree? React 👎 to reject it for follow-up reviews. A reply explaining why helps too.
This agent never approves PRs. A maintainer must sign off.
Only a maintainer can re-request a review from this agent.
Powered by Eclipse Enclave via review-guard-mcp
Docs-only PR: adds an optional step 0 to the README's First use list that recommends installing Eclipse Enclave, says briefly what it gives you (one container per agent, full autonomy, filtered network), and links Enclave's getting-started guide.
I checked the claims against the code. Enclave availability is checked live (exec.LookPath on each Available call), so installing it after the daemon is already running works without a restart. The provider selector in the new-session form matches "pick Eclipse Enclave as the provider". Line lengths and the reference-style link follow the README's existing conventions. none in the changelog block is fine for a README-only change. There's no UI change, so I skipped visual testing.
Two inline points for a maintainer:
- The Install section already mentions the
enclaveCLI, so this puts the recommendation in a second place. It also means a software install now sits under First use, after Run. - "Sessions you start with
enclavein a terminal show up too" claims more than the code does. Only sessions in a project's folder get adopted.
Clarify instructions for starting a session with Eclipse Enclave.
What and why
The README barely mentions Eclipse Enclave. HomeShell works without it, but makes more sense with
it, so First use gets an optional step 0 that recommends installing Enclave and links to its
getting-started guide.
Changelog
Checklist
AGENTS.md) — docs onlyAGENTS.md