Give the default shell the bottom room the other three already have - #1555
Conversation
The About page ends in the newsletter section and it sat flush against the bottom of the viewport. The cause is not the section: DefaultShell's main had a top margin and nothing below it, while every other shell already reserves the room (journal and terminal pb-16, reader py-6 on its inner column), so this was true of the last element on every page it frames.
|
Warning Review limit reached
Next review available in: 26 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoAdd bottom padding to DefaultShell content
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent |
Greptile SummaryAdds consistent bottom breathing room to pages rendered through
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The change adds static bottom padding to the default shell using the same spacing pattern as sibling shells, and affected callers do not supply conflicting bottom room.
|
| Filename | Overview |
|---|---|
| apps/self-hosted/src/features/blog/layout/default-shell.tsx | Adds compatible bottom padding to the shared default blog shell without introducing a concrete layout or behavioral defect. |
Reviews (1): Last reviewed commit: "Give the default shell the bottom room t..." | Re-trigger Greptile
Code Review by Qodo
1. Missing bottom-padding regression test
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| section, and the archive ends in a card. The other three shells | ||
| already reserve the same room (journal and terminal pb-16, reader | ||
| py-6 on its inner column); this one only ever had a top margin. */} | ||
| <main id="main-content" className="blog-main-container order-2 items-start mt-4 sm:mt-8 pb-16 section-gap-theme"> |
There was a problem hiding this comment.
1. Missing bottom-padding regression test 📘 Rule violation ▣ Testability
The PR fixes a previously incorrect layout behavior by adding pb-16 to DefaultShell, but the change set contains no automated regression test that verifies the last page content is separated from the viewport bottom. Without such a test, the fix can regress while the suite still passes.
Agent Prompt
## Issue description
The `DefaultShell` layout now adds `pb-16` to prevent the final page content from sitting flush against the viewport, but no regression test was added.
## Issue Context
The test must exercise a page rendered through `DefaultShell` and fail against the pre-fix class without `pb-16`, then pass with the new class. Assert the observable rendered layout/class contract used by the project’s test setup.
## Fix Focus Areas
- apps/self-hosted/src/features/blog/layout/default-shell.tsx[30-30]
- apps/self-hosted/src/specs/features/blog/
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
1 participant
Follow-up to #1552, from looking at the merged result: the About page ends in the newsletter section and it sat flush against the bottom of the viewport.
The cause is not that section.
DefaultShell's<main>carried a top margin and nothing below it, so the last element of every page it frames sat flush. The other three shells already reserve the room:<main className="pb-16"><main className="pb-16">py-6on its inner columnSo this is one class, in the shell, matching the value the other two already chose, rather than padding bolted onto the newsletter section. It fixes the archive's last card and the post page's last block on the same five templates (medium, minimal, magazine, developer, modern-gradient).
Verified: 1004 tests, typecheck clean,
rsbuild buildclean with the node-globals check passing.