Skip to content

chore: bump @ecency/sdk to 2.3.83 and drop the wallet history initialData guard - #3493

Merged
feruzm merged 1 commit into
developmentfrom
bugfix/sdk-2383-drop-initialdata-guard
Aug 11, 2026
Merged

chore: bump @ecency/sdk to 2.3.83 and drop the wallet history initialData guard#3493
feruzm merged 1 commit into
developmentfrom
bugfix/sdk-2383-drop-initialdata-guard

Conversation

@feruzm

@feruzm feruzm commented Aug 11, 2026

Copy link
Copy Markdown
Member

Raises the @ecency/sdk floor to ^2.3.83 (published from ecency/vision-web#1427) and removes the initialData: undefined override on the wallet history chain query. The guard's own comment gated its removal on an SDK spec pinning the absence of the empty seed; 2.3.83 ships that spec for both the notifications options and the HIVE/HBD/HP asset transaction options, so the contract is enforced upstream now.

Verified: typecheck clean against the empty baseline, lint 0 errors, 821 jest tests pass.

Closes #3492

Summary by CodeRabbit

  • Bug Fixes
    • Improved loading behavior for chain activity history by relying on standard query defaults.
  • Chores
    • Updated the Ecency SDK to the latest patch version.

…Data guard

sdk 2.3.83 ships a spec pinning that the notifications and HIVE/HBD/HP
asset transaction options carry no initialData seed, which is the exact
condition the local guard documented for its own removal.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f3ce70a-c8b8-4523-9ad4-e52ed6814036

📥 Commits

Reviewing files that changed from the base of the PR and between f218f12 and 27a3b02.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json
  • src/providers/queries/walletQueries/walletQueries.ts

📝 Walkthrough

Walkthrough

The PR updates @ecency/sdk to ^2.3.83 and removes the redundant initialData: undefined override from the wallet activity infinite query.

Changes

Wallet history contract

Layer / File(s) Summary
Align wallet query with SDK contract
package.json, src/providers/queries/walletQueries/walletQueries.ts
The project requires @ecency/sdk ^2.3.83. The wallet activity query now relies on SDK-provided initial data behavior and updates its comments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Poem

A bunny checks the wallet flow,
No empty seed is placed below.
The SDK guides each page along,
With version bumps, the query’s strong.
Hop, hop—history moves on!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The dependency bump and guard removal match #3492, but the summary shows the required workaround comment was deleted rather than updated. Add or revise the wallet history comment to state that SDK 2.3.83 pins the no-initialData contract.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the SDK dependency bump and wallet history guard removal.
Out of Scope Changes check ✅ Passed All reported changes are limited to the SDK dependency bump and wallet history query guard covered by #3492.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/sdk-2383-drop-initialdata-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@feruzm
feruzm merged commit 6dd2e7f into development Aug 11, 2026
8 checks passed
@feruzm
feruzm deleted the bugfix/sdk-2383-drop-initialdata-guard branch August 11, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump @ecency/sdk to 2.3.83 and drop the local initialData guard on wallet history

1 participant