Topology utils#275
Open
mahdiehmalekian wants to merge 1 commit into
Open
Conversation
Fix import Fix syntax
mahdiehmalekian
force-pushed
the
topology_utils
branch
from
June 24, 2026 01:09
d1303ed to
1da2b4c
Compare
Author
|
@thisac Is this ready to be merged? |
randomir
reviewed
Jul 17, 2026
randomir
left a comment
randomir
left a comment
Member
There was a problem hiding this comment.
Did a quick review, it looks good, but I would like to do an in-depth review before me merge this.
The suggestions below are mostly minor, except the use of function objects as default argument values.
| @@ -0,0 +1,20 @@ | |||
| # Copyright 2016 D-Wave Systems Inc. | |||
Member
There was a problem hiding this comment.
Suggested change
| # Copyright 2016 D-Wave Systems Inc. | |
| # Copyright 2026 D-Wave Systems Inc. |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # ================================================================================================ |
Member
There was a problem hiding this comment.
Suggested change
| # ================================================================================================ |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # ================================================================================================ |
Member
There was a problem hiding this comment.
Suggested change
| # ================================================================================================ |
| return self._edge[index] | ||
|
|
||
| def __eq__(self, other: object) -> bool: | ||
| if not type(self) is type(other): |
Member
There was a problem hiding this comment.
Suggested change
| if not type(self) is type(other): | |
| if type(self) is not type(other): |
|
|
||
| def __eq__(self, other: object) -> bool: | ||
| if not type(self) is type(other): | ||
| return NotImplemented |
Member
There was a problem hiding this comment.
Why not:
Suggested change
| return NotImplemented | |
| return False |
| def neighbors( | ||
| self, | ||
| nbr_kind: EdgeKind | Iterable[EdgeKind] | None = None, | ||
| where: Callable[[Coord], bool] = lambda coord: True, |
Member
There was a problem hiding this comment.
I believe the mutable default argument value gotcha applies to function objects as well.
| associated_edgekind: EdgeKind | ||
|
|
||
|
|
||
| class HasInternalNeighborsMixin(NeighborContributorMixin): |
| Returns: | ||
| TopologyShape: The shape converted to its corresponding quotient shape. | ||
| """ | ||
| @abstractmethod |
Member
There was a problem hiding this comment.
Suggested change
| @abstractmethod | |
| @abstractmethod | |
Comment on lines
+524
to
529
| source_to_inner = _chimera_coordinates_cache[m_s, | ||
| n_s, t_t].linear_to_chimera | ||
| else: | ||
| raise ValueError(f"Chimera node labeling {labels_s} not recognized") | ||
| raise ValueError( | ||
| f"Chimera node labeling {labels_s} not recognized") | ||
|
|
Member
There was a problem hiding this comment.
Not sure if this was automatically reformatted, or you did it manually, but indentation should be at least locally consistent!
Comment on lines
+538
to
+539
| source_to_inner = _zephyr_coordinates_cache[m_s, | ||
| t].linear_to_zephyr |
Member
There was a problem hiding this comment.
This is arguably less readable to save 4-5 characters in a line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The added files in
dwave/graphs/topologies/commonprovide blueprint classes for working with different aspects of any D-Wave topology.coord.py: Coordinate systems used for node labels.node_edge.py: Nodes and edges.planeshift.py: Displacement of nodes in the Cartesian plane.shape.py: Shape of a graph.topology.py: Constructing a topology graph whose nodes and edges are equipped with all the specific-topology-relevant functionalities.The added files in
dwave/graphs/topologies/zephyr, i.e.zcoord.py,znode_edge.py,zplaneshift.pyandzshape.py, contain the implementation of the corresponding objects for Zephyr topology. Inzephyr.pythe classZephyrhas been added that is built onTopologyblueprint indwave/graphs/topologies/common/topology.pyThe test suite for these modules is added in
tests.Note: This is an evolution of previous
zephyr_utilsPR tominorminer.