Feature/chimera quotient search by jackraymond · Pull Request #54 · dwavesystems/dwave-experimental

jackraymond · 2026-06-07T20:01:44Z

Expanded functionality to support Chimera and Pegasus quotient search alongside Zephyr (already implement).

Some refactorization of functions.

Expansion of the example to plot results, and use quotient search over a defect (rather than fully yielded) lattice.

…s WIP, functional tested in context of the example

…rdinate scheme, without changing behaviour

…y functionally with respect to all three families

jackraymond · 2026-06-08T20:20:13Z

TO DO:

Example is failing for some seeds. Seems to be related to casting numpy integers to/from regular integers within tuples (can fix).
Instead of using (m,t) and casting to (m,m,t) and (m,) respectively for Pegasus and Chimera, it might be tidier to use either a shape tuple for the graph [e.g. the output of qpu.properties['topology']['shape']] == first ordered parameters for graph generators and other graph-family specific functions]
(done) The zephyr example doesn't show the rails nicely due to too many overlapping edges, edges can be reordered so blue is plotted on top.

VolodyaCO

I've given a first complete pass at this PR and it looks good overall. I just have a few minor comments. I'm also triggering copilot review to catch other nuisances.

Edit: I should also mention that I ran the example and tests locally and they worked.

…earch

thisac

Some early comments. Still have to go through it in more detail.

VolodyaCO

Apart from Theo's comments, I think this looks good. Thanks Jack!

Co-authored-by: mahdiehmalekian <58615019+mahdiehmalekian@users.noreply.github.com> Co-authored-by: Theodor Isacsson <tisacsson@dwavesys.com>

…uffling.

jackraymond · 2026-08-27T08:36:30Z

Review elements are all implemented. However, per recommendations we should do the following:

Rebase to an updated dwave-experimental not using the deprecated networkx routines (any reason we can't do this for our other repos, minorminer has to be done for 2.).
Move the labeled_subgraph.py module and tests to a pull request on minorminer.
After completing 1 and 2, make a pull request on dwave-experimental where file/git history is tidied up and superficial changes are minimized (otherwise same code).

… transformation functions

jackraymond · 2026-09-02T17:41:08Z

Pull request is deprecated by this PR: dwavesystems/minorminer#292
Conditioned on this being accepted I'll follow up with a more specific dwave-experimental pull request. Changing this PR to draft

jackraymond added 11 commits June 5, 2026 22:20

Add interface level support for non-zephyr graphs

902ec41

Rename to reflect generalization from zephyr

55fef44

Support pegasus and chimera quotient graphs, chimera working - pegasu…

478a0db

…s WIP, functional tested in context of the example

Bugfix pegasus rail_nodes()

7667e41

Tests and examples consistent

7176fda

Update zephyr specific descriptions and conventions

911161a

Add matplotlib requirement

07b4fdd

Release note

f82d5e0

Modify _node_seaarch to use abstract iterators not tied to zephyr coo…

ba2df75

…rdinate scheme, without changing behaviour

Add _nodee_seach implementations for Chimera and Zephyr: code is full…

8460f1d

…y functionally with respect to all three families

Add quotient and rail examples to demo script

4fd202f

jackraymond added 6 commits June 11, 2026 12:21

Replace dwave_networkx dependencies by dwave.graphs dependencies

a86ac35

Add hinted search by orientation, quotient or optimal coloring

8fd1ece

Add docstrings. Add support for non-coordinate graphs

3ea3ebf

bugfix node labeling methods

6c5acd8

Protect against raises from edge case use of yield_type and strategy

e5eea90

Formatting

6bac196

jackraymond mentioned this pull request Jul 8, 2026

Default tolerant zephyr models dwave-examples/image-generation#33

Open

randomir requested a review from mahdiehmalekian July 28, 2026 17:31

jackraymond commented Jul 29, 2026

View reviewed changes

Comment thread dwave/experimental/embedding_methods/quotient_embedding_search.py

VolodyaCO reviewed Aug 25, 2026

View reviewed changes

Comment thread dwave/experimental/embedding_methods/quotient_embedding_search.py Outdated

jackraymond added 7 commits August 25, 2026 09:22

Fix chimera_two_color bug and expand testing per review

250cc4a

Update docstring to make clear limitations of color-hinted subgraph s…

46fc87c

…earch

Update imports from dwave_networkx to dwave.graphs

bc737bc

Correct multi-line string formatting

5c89aca

Implement review recommendations

9971c5d

implement review

c2c216c

Add comment to do -> potential enhancement, left as future work

a103501

Implement review

7266805

thisac reviewed Aug 25, 2026

View reviewed changes

VolodyaCO approved these changes Aug 25, 2026

View reviewed changes

thisac reviewed Aug 26, 2026

View reviewed changes

mahdiehmalekian reviewed Aug 26, 2026

View reviewed changes

jackraymond and others added 10 commits August 26, 2026 21:11

Apply suggestions from code review

c3eaf1b

Co-authored-by: mahdiehmalekian <58615019+mahdiehmalekian@users.noreply.github.com> Co-authored-by: Theodor Isacsson <tisacsson@dwavesys.com>

Change case based branching to use python 3.10 match. Add types

e1097dd

Save example figures to figures/ subdirectory, add this to .gitignore

df7d54d

Review implementation

6c274a2

Implement simple part of mahdiehs review

eee4d30

Refactor module structure

3ec9f15

Fix labeled_subgraph coverage issues

48a47fe

Remove redundant blocks and raise coverage for quotient_embedding_search

85d6882

Standardize line lengths

a5d54c0

Review recommendation: update node search to prevent score-neutral sh…

10c53dd

…uffling.

jackraymond added 2 commits August 28, 2026 15:02

Update labeled subgraph to make use of simpler generalized coordinate…

2e4a23e

… transformation functions

Refactor graph labeling parts

2331f13

jackraymond mentioned this pull request Aug 28, 2026

Support for graph labelings that enhance effectiveness of find_subgraph dwavesystems/minorminer#292

Open

Add literal option

d2e7715

jackraymond marked this pull request as draft September 2, 2026 17:41

Conversation

jackraymond commented Jun 7, 2026

Uh oh!

jackraymond commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

VolodyaCO left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thisac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VolodyaCO left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jackraymond commented Aug 27, 2026

Uh oh!

jackraymond commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jackraymond commented Jun 8, 2026 •

edited

Loading

VolodyaCO left a comment •

edited

Loading

jackraymond commented Sep 2, 2026 •

edited

Loading