Repository navigation
[msbuild] Explain codesign failures caused by extended attributes. Fixes #5202 - #26910
rolfbjarne wants to merge 1 commit into
Conversation
Detect the resource fork/Finder information failure in Codesign and add a localized diagnostic for each affected bundle. Preserve the original error and explain how to locate offending files with xattr, clear attributes from the source files, and rebuild, with a link to Apple's troubleshooting documentation. Only inspect codesign output after a failure; do not scan or modify file metadata during normal builds. Add regression coverage for multiple bundles, paths containing spaces, unrelated failures, successful signing, and stamp-file behavior. Fixes #5202 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6e358f10-7a38-45b3-8e9b-a64b1a0f4aa6
There was a problem hiding this comment.
🔵 Needs a closer look
Required CI results remain unverified despite the reported local test success.
1 open issue
What changed in this PR
Improves Codesign troubleshooting for extended-attribute failures, addressing #5202 without scanning or modifying file metadata.
Changes:
- Adds a localized diagnostic while preserving the original error.
- Explains how to locate affected files, remove source attributes, and rebuild.
- Adds regression coverage for multiple bundles, spaces, failure types, successful signing, and stamp files.
| File | Description |
|---|---|
| tests/msbuild/Xamarin.MacDev.Tasks.Tests/TaskTests/CodesignTaskTests.cs | Tests diagnostic and stamp-file behavior. |
| msbuild/Xamarin.MacDev.Tasks/Tasks/Codesign.cs | Detects the specific signing failure. |
| msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx | Adds troubleshooting guidance and an Apple documentation link. |
Review effort: Balanced
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
1 similar comment
🔥 [CI Build #8432834] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 0 tests failed, 218 tests passed. Failures❌ windows tests🔥 Failed catastrophically on VSTS: test results - windows (no summary found). Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Detect the resource fork/Finder information failure in Codesign and add a localized diagnostic for each affected bundle. Preserve the original error and explain how to locate offending files with xattr, clear attributes from the source files, and rebuild, with a link to Apple's troubleshooting documentation.
Only inspect codesign output after a failure; do not scan or modify file metadata during normal builds. Add regression coverage for multiple bundles, paths containing spaces, unrelated failures, successful signing, and stamp-file behavior.
Validation: all 7 CodesignTaskTests pass after rebasing onto main.
Fixes #5202
🤖 Pull request created by Copilot