Skip to content

[WebKit] Preserve native defaults for unhandled policy events. Fixes #4214 #26897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolfbjarne wants to merge 1 commit into
base: main
Choose a base branch
from
+59 −0
Open

[WebKit] Preserve native defaults for unhandled policy events. Fixes #4214 #26897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/webkit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2429,6 +2429,7 @@ partial interface WebPolicyDelegate {
<summary>To be added.</summary>
<remarks>To be added.</remarks>
""")]
[NoDefaultValue]
void DecidePolicyForNavigation (WebView webView, NSDictionary actionInformation, NSUrlRequest request, WebFrame frame, NSObject decisionToken);

/// <param name="webView">To be added.</param>
Expand All @@ -2442,6 +2443,7 @@ partial interface WebPolicyDelegate {
<summary>To be added.</summary>
<remarks>To be added.</remarks>
""")]
[NoDefaultValue]
void DecidePolicyForNewWindow (WebView webView, NSDictionary actionInformation, NSUrlRequest request, string newFrameName, NSObject decisionToken);

/// <param name="webView">To be added.</param>
Expand All @@ -2455,6 +2457,7 @@ partial interface WebPolicyDelegate {
<summary>To be added.</summary>
<remarks>To be added.</remarks>
""")]
[NoDefaultValue]
void DecidePolicyForMimeType (WebView webView, string mimeType, NSUrlRequest request, WebFrame frame, NSObject decisionToken);

/// <param name="webView">To be added.</param>
Expand Down
56 changes: 56 additions & 0 deletions tests/monotouch-test/WebKit/WebViewTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

#nullable enable

#if __MACOS__

using WebKit;

namespace MonoTouchFixtures.WebKit {
[TestFixture]
[Preserve (AllMembers = true)]
public class WebViewTest {
[Test]
public void PolicyDelegateSelectors ()
{
using var view = new WebView ();
view.UnableToImplementPolicy += (sender, e) => { };

var policyDelegate = view.WeakPolicyDelegate ?? throw new AssertionException ("Policy delegate was not created.");

var navigation = new Selector ("webView:decidePolicyForNavigationAction:request:frame:decisionListener:");
var newWindow = new Selector ("webView:decidePolicyForNewWindowAction:request:newFrameName:decisionListener:");
var mimeType = new Selector ("webView:decidePolicyForMIMEType:request:frame:decisionListener:");
var failure = new Selector ("webView:unableToImplementPolicyWithError:frame:");

void AssertSelectors (bool handlesNavigation, bool handlesNewWindow, bool handlesMimeType)
{
Assert.That (policyDelegate.RespondsToSelector (navigation), Is.EqualTo (handlesNavigation), "Navigation");
Assert.That (policyDelegate.RespondsToSelector (newWindow), Is.EqualTo (handlesNewWindow), "New window");
Assert.That (policyDelegate.RespondsToSelector (mimeType), Is.EqualTo (handlesMimeType), "MIME type");
Assert.That (policyDelegate.RespondsToSelector (failure), Is.True, "Failure notification");
}

EventHandler<WebNavigationPolicyEventArgs> navigationHandler = (sender, e) => { };
EventHandler<WebNewWindowPolicyEventArgs> newWindowHandler = (sender, e) => { };
EventHandler<WebMimeTypePolicyEventArgs> mimeTypeHandler = (sender, e) => { };

AssertSelectors (false, false, false);
view.DecidePolicyForNavigation += navigationHandler;
AssertSelectors (true, false, false);
view.DecidePolicyForNewWindow += newWindowHandler;
AssertSelectors (true, true, false);
view.DecidePolicyForMimeType += mimeTypeHandler;
AssertSelectors (true, true, true);
view.DecidePolicyForNavigation -= navigationHandler;
AssertSelectors (false, true, true);
view.DecidePolicyForNewWindow -= newWindowHandler;
AssertSelectors (false, false, true);
view.DecidePolicyForMimeType -= mimeTypeHandler;
AssertSelectors (false, false, false);
}
}
}

#endif
Loading