Repository navigation
perf: Discard Docker healthcheck response body - #114
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discard the body returned by the Proxmox web healthcheck while preserving curl's existing HTTP/TLS and failure behavior. The healthcheck runs every 60 seconds, so this avoids repeatedly capturing an unused response body in the container runtime logs. This is a small, low-risk change; no benchmark is claimed.
Review findings
Other performance opportunities identified during review:
src/network.sh— cache route-table output in subnet collision checks instead of querying and filtering it for each candidate subnet.src/entrypoint.sh— avoid startingqemu-imgand creating/removing a probe file during kernel feature checks on every start.src/entrypoint.sh— reduce repeated scans of/proc/cpuinfoin the KVM CPU-flag check.src/network.sh— simplify IPv4 address discovery to oneip -4 -o/awkpipeline.src/network.sh— parse driver and bus from oneethtool -iinvocation in a singleawkprocess.src/network.sh— replace per-interfacesedsubprocesses in interface configuration generation with one pass.src/network.sh— reuse already-read firewall chain output in DEBUG conflict diagnostics.src/network.sh— reduce repeatediptables-savecalls during firewall backend fallback and verification.src/entrypoint.sh— skip redundantmkdir,chown, andchmodwork for runtime directories already in the desired state.Dockerfile— suppress unused healthcheck output (implemented here).Validation
git diff --checkpasses. This is a Dockerfile healthcheck-command-only change; no runtime benchmark or container integration test was run.