Skip to content

perf: Discard Docker healthcheck response body - #114

Merged
kroese merged 1 commit into
dockur:masterfrom
2tank0:2tank0-proxmox-performance-review
Oct 14, 2026
Merged

kroese merged 1 commit into
dockur:masterfrom
2tank0:2tank0-proxmox-performance-review

Conversation

@2tank0

@2tank0 2tank0 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Discard the body returned by the Proxmox web healthcheck while preserving curl's existing HTTP/TLS and failure behavior. The healthcheck runs every 60 seconds, so this avoids repeatedly capturing an unused response body in the container runtime logs. This is a small, low-risk change; no benchmark is claimed.

Review findings

Other performance opportunities identified during review:

  1. src/network.sh — cache route-table output in subnet collision checks instead of querying and filtering it for each candidate subnet.
  2. src/entrypoint.sh — avoid starting qemu-img and creating/removing a probe file during kernel feature checks on every start.
  3. src/entrypoint.sh — reduce repeated scans of /proc/cpuinfo in the KVM CPU-flag check.
  4. src/network.sh — simplify IPv4 address discovery to one ip -4 -o/awk pipeline.
  5. src/network.sh — parse driver and bus from one ethtool -i invocation in a single awk process.
  6. src/network.sh — replace per-interface sed subprocesses in interface configuration generation with one pass.
  7. src/network.sh — reuse already-read firewall chain output in DEBUG conflict diagnostics.
  8. src/network.sh — reduce repeated iptables-save calls during firewall backend fallback and verification.
  9. src/entrypoint.sh — skip redundant mkdir, chown, and chmod work for runtime directories already in the desired state.
  10. Dockerfile — suppress unused healthcheck output (implemented here).

Validation

git diff --check passes. This is a Dockerfile healthcheck-command-only change; no runtime benchmark or container integration test was run.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kroese kroese changed the title perf: discard Docker healthcheck response body perf: Discard Docker healthcheck response body Oct 14, 2026
@kroese
kroese merged commit ad6305f into dockur:master Oct 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants