fix: support node.js runtime in wasm storage service#553
Merged
maycon-mello merged 4 commits intoJul 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make the WASM StorageService work in Node.js runtimes by providing a localStorage fallback (via node-localstorage) when a native Web Storage implementation isn’t available.
Changes:
- Added a
getStore()helper to choose between a nativelocalStorageand a Node.jsnode-localstoragefallback. - Updated storage operations to use
getStore()and revisedgetAllKeys()to enumerate keys via the Web Storage API. - Added
node-localstorageas a dependency and marked it as external in the WASM Rollup build.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/wasm/src/services/storage/service.ts | Introduces getStore() abstraction and updates storage methods to use it, plus key enumeration changes. |
| packages/wasm/rollup.config.mjs | Adds node-localstorage to Rollup externals. |
| packages/wasm/package.json | Adds node-localstorage dependency for the WASM package. |
| package-lock.json | Locks node-localstorage dependency version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f712f25 to
23be5ae
Compare
mike-parkhill
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.