Skip to content

fix(store): ignore ErrNotExist when removing incomplete blob file #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
doringeman wants to merge 1 commit into from
+2 −1
Closed

fix(store): ignore ErrNotExist when removing incomplete blob file #916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/distribution/internal/store/blobs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package store
import (
"crypto/sha256"
"encoding/hex"
"errors"
"fmt"
"io"
"os"
Expand Down Expand Up @@ -221,7 +222,7 @@ func (s *LocalStore) WriteBlobWithResume(diffID oci.Hash, r io.Reader, digestStr
}
} else {
// No Range success or offset mismatch - start fresh
if removeErr := os.Remove(incompletePath); removeErr != nil {
if removeErr := os.Remove(incompletePath); removeErr != nil && !errors.Is(removeErr, os.ErrNotExist) {
return fmt.Errorf("remove incomplete file: %w", removeErr)
}
var createErr error
Expand Down