ci(e2e): use GITHUB_TOKEN for GHCR e2e#1554
Merged
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
thaJeztah
reviewed
Jun 4, 2026
| # reusable workflow | ||
| name: .e2e-run | ||
|
|
||
| permissions: |
Member
Author
There was a problem hiding this comment.
Because we introduce packages: write and caller should take care of permissions, not the reusable workflow. There is some analysis here: docker/github-builder#24
thaJeztah
reviewed
Jun 4, 2026
| @@ -0,0 +1,6 @@ | |||
| rules: | |||
| # rule does not apply to reusable worfklows where permissions are defined by | |||
Member
There was a problem hiding this comment.
ah, right; so wouldn't it still make sense to set defaults, or won't that work?
Member
Author
There was a problem hiding this comment.
Yeah that won't work unfortunately, see docker/github-builder#24
Member
There was a problem hiding this comment.
That's annoying! Is it a known issue in zizmor? Is this something that could be fixed in GitHub actions itself?
Member
Author
There was a problem hiding this comment.
I think this is tracked inb zizmor yeah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the e2e workflow so GHCR authentication uses the workflow
GITHUB_TOKENinstead of a stored PAT.The caller workflow grants
packages: writeto the reusable e2e job, and the reusable workflow falls back togithub.actorandsecrets.GITHUB_TOKENwhen the registry isghcr.io.This removes the need for a long-lived GHCR PAT while keeping the generic registry secret mapping focused on external registries.