✨ Bump Agent Sandbox to v1.0.0 - #1
Closed
djzager wants to merge 1 commit into
Closed
Conversation
Update the sigs.k8s.io/agent-sandbox dependency from v0.5.0 to v1.0.0. v1.0.0 restructured SandboxSpec (PodTemplate and Service moved into an embedded SandboxBlueprint), so createSandbox builds the Sandbox CR through the new shape; the serialized Sandbox is unchanged. The e2e kind install tag (AGENT_SANDBOX_TAG) now derives from go.mod so it can't drift from the compiled API, and README/docs target v1.0.x with an in-place-upgrade note (v1.0.0 removes the legacy v1alpha1 API and conversion webhooks). The transitive k8s.io/* bump to v0.36.4 is required by agent-sandbox v1.0.0's own go.mod; the rest fall out of go mod tidy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
Wrong base — reopening against konveyor/agentic-controller (main). Superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
sigs.k8s.io/agent-sandboxfrom v0.5.0 → v1.0.0.Why / what changed
agent-sandbox v1.0.0. The transitivek8s.io/* → v0.36.4bump (and the otel/grpc/etc. moves) is required by agent-sandbox v1.0.0's own go.mod; the rest fall out ofgo mod tidy.SandboxSpec(PodTemplateandServicemoved into an embeddedSandboxBlueprint), socreateSandboxnow builds the CR through the new shape. The controller still consumes only thev1beta1API and the serialized Sandbox is unchanged.hack/start-kind.shnow derivesAGENT_SANDBOX_TAGfrom go.mod (viago -C … list -m) so the deployed CRDs can't drift from the compiled API, mirroring the go.mod-derived CRD path insuite_test.go. Env override preserved.v1alpha1API and conversion webhooks; existing clusters must migrate via v0.5.2+ before upgrading).Testing
go build ./...✅make test✅ — 79 controller specs pass;manifests/generateproduced no CRD/RBAC drift (theagents.x-k8s.iogroup is unchanged), confirming the API is compatible.🤖 Generated with Claude Code