Skip to content

use std::string_view for safe_string2int #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kroening merged 2 commits into from
May 27, 2026

Use string_view::substr at call sites to avoid copies

8af8647
Select commit
Loading
Failed to load commit list.
Merged

use std::string_view for safe_string2int #9009

Use string_view::substr at call sites to avoid copies
8af8647
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 26, 2026 in 1s

80.56% (+0.00%) compared to 258b08c

View this Pull Request on Codecov

80.56% (+0.00%) compared to 258b08c

Details

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.56%. Comparing base (258b08c) to head (8af8647).

Files with missing lines Patch % Lines
src/goto-instrument/skip_loops.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #9009   +/-   ##
========================================
  Coverage    80.56%   80.56%           
========================================
  Files         1707     1707           
  Lines       189118   189134   +16     
  Branches        73       73           
========================================
+ Hits        152363   152385   +22     
+ Misses       36755    36749    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov