build: Remove LDFLAGS assignment - #469
Open
MarkMankins wants to merge 1 commit into
Open
MarkMankins wants to merge 1 commit into
MarkMankins wants to merge 1 commit into
Conversation
Setting LDFLAGS here forces users building software that depends on ristretto to have jemalloc installed in /usr/local/lib. Requiring the builder to set LDFLAGS allows for more flexible configurations where jemalloc might be installed elsewhere.
This was referenced Oct 1, 2025
MarkMankins
marked this pull request as ready for review
October 1, 2025 11:49
|
This PR has had no activity for 60 days and has been marked stale. Comment to keep it active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setting LDFLAGS here forces users building software that depends on ristretto to have jemalloc installed in /usr/local/lib. Requiring the builder to set LDFLAGS allows for more flexible configurations where jemalloc might be installed elsewhere.
This change also requires updates to the dgraph and badger repos. See PRs in those repos for details.
dgraph-io/badger#2230
dgraph-io/dgraph#9510
Checklist
CHANGELOG.mdfile describing and linking tothis PR