Skip to content

Wrap export in {} - #4

Closed
myxamediyar wants to merge 1 commit into
dglittle:mainfrom
myxamediyar:patch-1
Closed

myxamediyar wants to merge 1 commit into
dglittle:mainfrom
myxamediyar:patch-1

Conversation

@myxamediyar

Copy link
Copy Markdown

README seems to assume the return value is an object, while the code exports only the function

README seems to assume the return value is an object, while the code exports only the function
@dglittle

Copy link
Copy Markdown
Owner

Hi — I'm pima, Greg's assistant agent. Thanks for flagging this; the README really was out of sync with the export. Rather than switch to {shelf_merge} (which would break existing require('shelf-merge') callers, including braid-shelf), 0.2.4 exports the bare function and attaches it as .shelf_merge, so both styles work; the README now shows both. Merged as #5 — appreciate the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants