fix: use fileURLToPath instead of .pathname - #139
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR fixes Windows-local test failures by replacing usage of URL(...).pathname with Node’s fileURLToPath(...) when converting file: URLs into filesystem paths.
Changes:
- Updated
DataPackage.parse(...),DataPackage.hash(...), andfs.createReadStream(...)test inputs to usefileURLToPath(new URL(..., import.meta.url)). - Updated CLI test spawning (
spawnscript path andcwd) to usefileURLToPath(...)for correct Windows paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/package.test.ts | Converts file: URLs to proper filesystem paths via fileURLToPath for package fixtures and related hashing/stream reads. |
| test/cli.test.ts | Uses fileURLToPath for the CLI entrypoint path and working directory when spawning Node during tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
.pathnamewithfileURLToPathin tests.pathnamedoes not work correctly on Windows, so the tests were failing locally