#1886: fix npm based commandlet shows wrong tool version

[AdemZarrouki]

This PR fixes #1886

Implemented changes:

• Override getInstalledVersion in NpmBasedCommandlet to ignore the toolPath parameter and use npm package manager to detect the actual installed version of the tool.

---

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

• When running mvn clean test locally all tests pass and build is successful
• PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
• PR top-level comment summarizes what has been done and contains link to addressed issue(s)
• PR and issue(s) have suitable labels
• Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
• You followed all coding conventions
• You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
  with internal

[coveralls]

Coverage Report for CI Build 26214647811

Coverage increased (+0.02%) to 70.972%

Details

• Coverage increased (+0.02%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/tools/ide/version/VersionSegment.java	1	89.24%

---

Coverage Stats

Relevant Lines:	15517
Covered Lines:	11489
Line Coverage:	74.04%
Relevant Branches:	6934
Covered Branches:	4445
Branch Coverage:	64.1%
Branches in Coverage %:	Yes
Coverage Strength:	3.13 hits per line

---

💛 - Coveralls

[areinicke]

I have confirmed it works and the few lines of code you added look good. Nice job!

[hohwille]

@AdemZarrouki thanks for your PR. Great that you figured out why we have this bug 👍
I left a comment for a better place to fix it so it will not only be fixed for npm based tools but also for pip based tools.

[hohwille]

great finding. You traced down the bug.
However, a better or more proper fix would be to override this method in PackageManagerBasedLocalToolCommandlet that only overrides the method without the argument:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/PackageManagerBasedLocalToolCommandlet.java

Lines 178 to 181 in b4eeee2

	public VersionIdentifier getInstalledVersion() {
	return this.installedVersion.get();
	}

[AdemZarrouki]

Thanks for the review @hohwille.
Yes your comment makes sense as i wasn't aware that the bug is also in pip based commandlets.