#1802 GUI State management implementation by laim2003 · Pull Request #1807 · devonfw/IDEasy

laim2003 · 2026-04-09T11:39:21Z

This PR fixes #1802

Implemented changes:

Implemented basic State Management for the IdeContext in the GUI
State management should be thread safe: Thread safe singleton implementation
Added custom adaption of JavaFXs alert class for IDEasy

Main points:

Basic state management
Start-context <-> context seperation
Ensure thread safety
Callback pattern for any dependent compontents

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

When running mvn clean test locally all tests pass and build is successful
PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
PR top-level comment summarizes what has been done and contains link to addressed issue(s)
PR and issue(s) have suitable labels
Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
You followed all coding conventions
You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
with internal

- Added testing class for modals

- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.

- Added testing class for modals

- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.

…t-for-gui' into devonfw#1785-implement-modals-in-idecontext

- Added functionality, that selecting a different project now switches the IdeContext to the new project.

…plementation' into devonfw#1802-state-management-implementation

…r other ui feature branches

- added DI for IdeGuiStateManager.switchContext

coveralls · 2026-04-09T15:30:03Z

Coverage Report for CI Build 26781579041

Coverage decreased (-0.02%) to 71.076%

Details

Coverage decreased (-0.02%) from the base build.
Patch coverage: No coverable lines changed in this PR.
26 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

26 previously-covered lines in 4 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/ide/gui/App.java	13	0.0%
com/devonfw/ide/gui/MainController.java	11	62.96%
com/devonfw/ide/gui/AppLauncher.java	1	0.0%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java	1	78.33%

Coverage Stats


Relevant Lines:	15862
Covered Lines:	11754
Line Coverage:	74.1%
Relevant Branches:	7050
Covered Branches:	4531
Branch Coverage:	64.27%
Branches in Coverage %:	Yes
Coverage Strength:	3.13 hits per line

💛 - Coveralls

…reading the list of workspaces/projects instead of reading those from the UI

…nager, when switchContext(Path rootDirectory, ...) is called.

This reverts commit 6f92d93.

- not automatically select a workspace - to seperate concerns of which functions update the workspace combobox and which the project combobox

…low new Select-Project-Then-Select-Workspace UI logic (previous commit)

…of own implementation

…plementation' into devonfw#1802-state-management-implementation

hohwille

@laim2003 thanks for your PR.
I like the general design and you added many valuable fixes and improvements for the GUI.
I still have some doubts about the singleton and static member access approach.
Typically this will sooner or later cause trouble.
Maybe we can avoid this where possible.

Please avoid this extensive copy&paste of pointless and confusing properties, plugin settings that are never used, etc.
The golden rule for ide-projects for test is to keep them as minimalistic as possible.
Every line from such file and every entire file that can be removed without the test failing should be removed.

laim2003 · 2026-05-26T10:45:11Z

@laim2003 thanks for your PR. I like the general design and you added many valuable fixes and improvements for the GUI. I still have some doubts about the singleton and static member access approach. Typically this will sooner or later cause trouble. Maybe we can avoid this where possible.

Please avoid this extensive copy&paste of pointless and confusing properties, plugin settings that are never used, etc. The golden rule for ide-projects for test is to keep them as minimalistic as possible. Every line from such file and every entire file that can be removed without the test failing should be removed.

regarding the singleton design, i created a new ticket to document this #1975

…jectManager

hohwille

@laim2003 I now found the time to read and review the entire diff.
Thanks also for your rework. This PR is very nice progress and improvement. 👍
I left some further review remarks for improvement.
We should then finally merge this instead if dying in perfection.
There will be more rounds of changes in the GUI and we should stop blocking other stories that want to build on top of this...
However, I have always learned that we always need a solid foundation rather than a sandbank to build on top. So lets keep some pair of careful looking eyes on the GUI stuff that we are evolving...

hohwille · 2026-06-01T21:05:03Z

+          .filter(Files::isDirectory)
+          .map(Path::getFileName)
+          .map(Path::toString)
+          .filter(name -> !name.startsWith("_") && Files.exists(ideRootDirectory.resolve(name).resolve("workspaces")))


We should make this method reusable here:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java

Line 428 in 6080ee7

protected boolean isIdeHome(Path dir) {

We could even make it public if required.
BTW: The only forbidden or reserved project name is _ide and for that we have the constant IdeContext.FOLDER_UNDERSCORE_IDE.
I do not think users should do ide create _project - but I guess it is technically possible.

Ahh yes, this was a remaining fragment from the original implementation from the first MVP. I guess, I will change this so only folders matching FOLDER_UNDERSCORE_IDE will be excuded.

hohwille · 2026-06-01T21:06:06Z

@@ -0,0 +1 @@
+this is the foo-bar workspace


Everywhere else we just use empty .gitkeep files to add a folder to git. Shouldn't we follow this pattern here as well?

Oh ok, I will change this.

hohwille · 2026-06-01T21:08:19Z

@@ -0,0 +1 @@
+this is the foo-bar workspace


does it make sense to create project-0,..., project-5 that are all identical and have the same workspaces?
Actually if all this should make sense it would be more reasonable to have some differences between the workspaces so your test can really check if the workspaces found for some project really fit to that project and are not from a different one...

hohwille · 2026-06-01T21:11:07Z

+    projectManager = new ProjectManager(ideRoot);
+
+    assertThat(projectManager).isNotNull();
+    assertThat(projectManager.getProjectNames()).containsExactlyInAnyOrder("project-0", "project-1", "project-2", "project-3", "project-4", "project-5");


In cli we have added our test-infrastructure such that we can continuously add new code with new tests and potentially new test projects.
This will break as soon as we add a new test-project.
IMHO this does not really work out well for maintenance.
Maybe only assert that the project names contain these projects or filter the project names by a pattern project-[0-9] so other developers can later add foo and bar projects without breaking this test.

hohwille · 2026-06-01T21:13:11Z

+  void testRefreshProjects() throws IOException {
+
+    projectManager = new ProjectManager(ideRoot);
+    assertThat(projectManager.getProjectNames()).containsExactlyInAnyOrder("project-0", "project-1", "project-2", "project-3", "project-4", "project-5");


Also in JUnits we can consider reuse instead of copy&paste.
Consider adding List.of("project-0", "project-1", "project-2", "project-3", "project-4", "project-5") as a constant.
Then you can create a new list adding the constant + project-6.

hohwille · 2026-06-01T21:13:30Z

+
+    // Verify that test-project-no-workspaces is not recognized
+    assertThat(projectManager.getProjectNames()).doesNotContain("test-project-no-workspaces");
+    assertThat(projectManager.getProjectNames()).containsExactlyInAnyOrder("project-0", "project-1", "project-2", "project-3", "project-4", "project-5");


use constant.

hohwille · 2026-06-01T21:13:38Z

+
+    // Verify that _ide folder is not in the project names
+    assertThat(projectManager.getProjectNames()).doesNotContain("_ide");
+    assertThat(projectManager.getProjectNames()).containsExactlyInAnyOrder("project-0", "project-1", "project-2", "project-3", "project-4", "project-5");


use constant.

hohwille · 2026-06-01T21:15:35Z

+    for (String projectName : projectManager.getProjectNames()) {
+      assertThat(projectManager.getWorkspaceNames(projectName)).containsExactlyInAnyOrder("foo-test", "main");
+    }


This is what I was talking about. Then you could assert that project-1 has workspaces xyz and project-2 instead has abc (whatever).
And for test-data I have learned that it sooner or later hurts you if you use technical random instead of meaningful examples.

laim2003 added 13 commits March 27, 2026 17:52

devonfw#1296: implemented basic IdeDialog Class

029f03d

devonfw#1296: Added basic context state manager class

89cfb67

- Added testing class for modals

devonfw#1785: Added basic question/confirmation modal implementation

a53296d

- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.

devonfw#1296: implemented basic IdeDialog Class

37cad74

devonfw#1296: Added basic context state manager class

55a50ce

- Added testing class for modals

devonfw#1785: Added basic question/confirmation modal implementation

3f1569f

- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.

Merge remote-tracking branch 'origin/devonfw#1296-implement-idecontex…

6ce99b3

…t-for-gui' into devonfw#1785-implement-modals-in-idecontext

devonfw#1785: - Added logging to IdeGuiStateManager.

7ef65f3

- Added functionality, that selecting a different project now switches the IdeContext to the new project.

devonfw#1724: implemented basic gui state management

1764b2f

devonfw#1802: implemented basic gui state management

ddd3e5f

Merge remote-tracking branch 'origin/devonfw#1802-state-management-im…

9c5a720

…plementation' into devonfw#1802-state-management-implementation

devonfw#1802: removed a few changes so this branch can be the base fo…

b28e216

…r other ui feature branches

devonfw#1802: disabled javadoc warning

234e98b

github-project-automation Bot added this to IDEasy board Apr 9, 2026

github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 9, 2026

laim2003 self-assigned this Apr 9, 2026

laim2003 added GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx bugfix PR that fixes a bug issue core FileAccess, ProcessUtil, IdeContext, etc. labels Apr 9, 2026

laim2003 moved this from 🆕 New to 🏗 In progress in IDEasy board Apr 9, 2026

devonfw#1802: - fixed AppBaseTest being stuck

1c4e766

- added DI for IdeGuiStateManager.switchContext

laim2003 added 2 commits April 14, 2026 14:37

Merge branch 'main' into devonfw#1802-state-management-implementation

6fc3884

devonfw#1802: Added ProjectManager class to handle business logic of …

2026757

…reading the list of workspaces/projects instead of reading those from the UI

laim2003 added the internal Nothing to be added to CHANGELOG, only internal story label Apr 14, 2026

laim2003 added 5 commits April 14, 2026 18:12

devonfw#1802: Updated IdeGuiStateManager to also update its projectMa…

c76e185

…nager, when switchContext(Path rootDirectory, ...) is called.

devonfw#1802: javafx updated to java 25

6f92d93

Merge branch 'main' into devonfw#1802-state-management-implementation

9f741a5

Revert "devonfw#1802: javafx updated to java 25"

48fe018

This reverts commit 6f92d93.

devonfw#1803: added DI for IDE_ROOT in GuiStateManager

e0ad015

laim2003 added 3 commits April 28, 2026 18:04

devonfw#1802: Updated UI logic to:

9978ce9

- not automatically select a workspace - to seperate concerns of which functions update the workspace combobox and which the project combobox

devonfw#1802: cleaned up ProjectManagerTest, fixed AppBaseTest to fol…

ac3a045

…low new Select-Project-Then-Select-Workspace UI logic (previous commit)

devonfw#1802: cleaned up IdeGuiStateManagerTest

6c44432

laim2003 force-pushed the #1802-state-management-implementation branch from 459f762 to 6c44432 Compare April 28, 2026 17:28

Merge branch 'main' into devonfw#1802-state-management-implementation

c30c2ea

laim2003 moved this from 🏗 In progress to Team Review in IDEasy board Apr 28, 2026

laim2003 added 2 commits April 28, 2026 19:46

devonfw#1802: cleaned up ProjectManagerTest to use FileUtils instead …

1e8b556

…of own implementation

Merge remote-tracking branch 'origin/devonfw#1802-state-management-im…

d51111d

…plementation' into devonfw#1802-state-management-implementation

laim2003 marked this pull request as ready for review April 30, 2026 08:34

laim2003 moved this from Team Review to 👀 In review in IDEasy board May 2, 2026

laim2003 added 2 commits May 5, 2026 10:31

Merge branch 'main' into devonfw#1802-state-management-implementation

98a7072

Merge branch 'main' into devonfw#1802-state-management-implementation

c55a3a3

laim2003 mentioned this pull request May 12, 2026

#1784 implement java fx based progress bars for the GUI #1935

Draft

7 tasks

hohwille reviewed May 22, 2026

View reviewed changes

laim2003 added 9 commits May 26, 2026 15:34

devonfw#1802: cleaned up test folders, fixed wrong Logger used in Pro…

4747bae

…jectManager

devonfw#1802: cleaned up test folders devonfw#2

e03949d

devonfw#1802: cleaned up test folders nr. 3

e4e5bd9

Merge branch 'main' into devonfw#1802-state-management-implementation

44791ef

devonfw#1802: removed caching from ProjectManager

dab292f

devonfw#1802: cleanup

11a9546

devonfw#1802: cleanup

4781ea5

devonfw#1802: cleanup of ide.properties

9ee0bc2

Merge branch 'main' into devonfw#1802-state-management-implementation

9a76bfc

laim2003 requested a review from hohwille May 29, 2026 14:31

hohwille added 2 commits May 29, 2026 20:03

Merge branch 'main' into devonfw#1802-state-management-implementation

f504d35

Merge branch 'main' into devonfw#1802-state-management-implementation

99b617d

hohwille approved these changes Jun 1, 2026

View reviewed changes

laim2003 added 2 commits June 2, 2026 14:36

devonfw#1802: applied recommendations from @hohwille

dbe8c85

devonfw#1802: applied recommendations from @hohwille

666f0a7

Conversation

laim2003 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR fixes #1802

Implemented changes:

Checklist for this PR

Uh oh!

coveralls commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 26781579041

Coverage decreased (-0.02%) to 71.076%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

hohwille left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laim2003 commented May 26, 2026

Uh oh!

hohwille left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laim2003 Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

laim2003 commented Apr 9, 2026 •

edited

Loading

coveralls commented Apr 9, 2026 •

edited

Loading

laim2003 Jun 2, 2026 •

edited

Loading