Repository navigation
Read Никитич and Саввич as patronymics under locales.RU (#994) - #996
Merged
Merged
Conversation
The masculine patronymics of Никита and Савва fit neither -ович nor -евич, so `Петров Иван Никитич` under locales.RU read family 'Никитич'. Both join the irregular forms listed whole beside Ильич and Кузьмич, in Cyrillic and Latin, in all three copies of the pattern (_vocab, the config regexes and the RU pack's declared-deviation predicate). Their feminines already matched -ична. Closes #994 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #994.
НикитичandСаввичare the masculine patronymics of Никита and Савва. They fit neither-овичnor-евич, so rules/O1 (the East Slavic rotation) never fired on them:Both join the irregular forms listed whole beside
ильичandкузьмич, in Cyrillic (никитич|саввич) and Latin (nikitich|savvich). The pattern has three copies, and all three are changed:_pipeline/_vocab.py,config/regexes.py(the two held together bytest_regex_sync.py), andlocales/ru.py'sDEVIATESpredicate, which the non-interference gate reads. The feminines (Никитична,Саввична) already matched-ична.Tests. Four
_ROTATORS["ru"]rows (one per new alternation branch), the two words in both regex-collision tests, and a parse test intests/test_east_slavic_patronymic_order.py. Negative control: against the pre-fix patterns, 7 of the new or extended tests fail.Measurement. Scoring against datacoon/russiannames' 61,466 labelled Cyrillic names found the gap; that project's patronymic list gives Никитич a count of 1,225 and Саввич 160.
snapshot.pyreports no moves, since the snapshot parses the default policy, which this change doesn't reach. The release-log baseline (2.0.0 and 2.8.0 read family 'Никитич') was checked against the PyPI wheels.Docs. A dated entry in decisions/O1 (with
Кузмичexcluded), and a release-log bullet. rules/O1 says "patronymic ending" without listing forms, so it needs no amendment. The surname-plus-initials gap found alongside this is #995 and is not touched here.🤖 Generated with Claude Code