Repository navigation
Add the Catalan particles de, del and la to ca.toml (strict-gap batch C) - #1032
Merged
Merged
Conversation
ca.toml held the conjunction i alone, so strict ca read the particles of Catalan names as name words: 626, 208 and 197 records broken. No default or plain-choice parse moves; under strict ca, del and la read as never-given particles, which the reviewed ungated table records. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a cost, dels noted, recompute, counts dated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/design/decisions/vocabulary-model.md
# Conflicts: # docs/design/decisions/vocabulary-model.md # docs/release_log.rst # docs/usage.rst # nameparser/_types.py # nameparser/config/_index.py # tests/v2/pipeline/test_assemble.py # tests/v2/test_parser.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strict-gap batch C, decided on 2026-11-03: ca.toml takes
de,delandla, the particles of Catalan names (de la Torre,del Castell). It held the conjunctionialone, so strictcaread the rest as name words. Each entry copies es.toml's kind and properties.Measured
tools/differential/config_diff.py gapson master f48c88a, over the records of Spain and Andorra).cabroke 626 records onde, 208 ondeland 197 onla. The language's 1,032 broken records fall to 188 (simulated with all five batches).cawithout the particles happened to agree with the filed boxes.ijoining two surnames; a title and a credential beside them), the default, plaincaand strictca+esmove no cell.ca. It moves 35 cells, toward the default's reading, with the class batch B (Add the Spanish-derived particles of Filipino surnames to fil.toml (strict-gap batch B) #1031) met:delandlahold agivenreading in es.toml alone, so under strictcathey read as never-given particles.Del Castellreads family 'Del Castell', where the default reads given 'Del' and reports particle-or-given._reading_index.strict_ungated's reviewed table gainsca: del, la.Reading.languagesofdeandlanow namesca, so the release log, usage.rst,_types.pyand two tests list it.decisions/vocabulary-model gains the batch's entry.
Review round
An independent review found no defect. It reproduced the figures (198 broken and 26 fixed on this change alone, 188 and 25 with batch A), found plain
cabyte-identical over 61,582 local names, and read the 160 lost fixes: nearly all Spanish names whose filer boxeddel Carmenwith the given name, now read as plaincaand the default read them, with no Catalan name worse. Fixed after it:Castell, Del→ family 'Castell Del').dels, which no file holds, as left out.Checks
uv run pytest -q: 35,787 passed.uv run mypy,uv run ruff check.sphinx-build -b doctestand-W -b html;snapshot.py.-n0 -m serialand Python 3.15.Merge note: #1031 (fil) and #1033 (si) edit the same lists of files for
de(and #1031 forla), and #1031 and #1034 the same reviewed table. Whichever merges later takes every entry (('ca', 'es', 'fil', 'fr', 'it', 'nl', 'pt', 'si')fordeonce all three land) and rebuildsnameparser/config/_index.py. This batch's entry points to batch A's entry (#1030): merge #1030 first.🤖 Generated with Claude Code