deployment: Errors tab (application error detection)#270
Merged
Conversation
Add an Errors tab to the deployment detail view (non-Static) that surfaces grouped, deduplicated application-error issues from the error-detection pipeline (SPEC-error-detection.md, PR 4/7). - New route deployment/errors with issue list (kind badge, title, count, last-seen, status chip), Open/Resolved/Muted/All status pills, client-side text filter, and offset-cursor "Load more". - Expand-in-place issue detail: full sample stack in a monospace surface, recent occurrences (pod + relative time), and Resolve / Mute / Reopen GuardedButtons gated by deployment.logs. - States: empty, forbidden (no deployment.logs), and location-unavailable. - Add deployment.errors / errorGet / errorUpdate request+result types to src/types/api.d.ts and mock handlers (multi-kind/-status fixtures, two-page cursor paging, sg1 = location-unavailable) for bun dev:mock. All helpers (pod hue, relative-time, kind/severity) are local to the page; logFormat.ts is deliberately not created or imported (owned by another PR). bun check and bun lint are clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011d4bVuGLnCbcJD9ZvastPH
|
Preview deleted (PR closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 4/7 of application error detection (Sentry-lite —
SPEC-error-detection.md). Mines the deployment log stream for application-level errors (panics, exceptions, stack traces) and surfaces them as grouped, deduplicated issues.This PR adds the console Errors tab; it consumes the
deployment.errors/deployment.errorGet/deployment.errorUpdateAPI landed in earlier PRs.What the tab does
lastSeendesc; Load more follows the offsetnextCursor.sampleMessagestack in a monospace surface, plus recent occurrences (pod + relative time). Actions Resolve / Mute / Reopen areGuardedButtons gated bydeployment.logs; clicking callsdeployment.errorUpdatethen refetches.deployment.logs), and location-unavailable ("Error detection isn't available for this location yet." — when the list returns the unavailable error).Reused patterns
GuardedButton+ the permission contextcan()for the triage actions.api.invoke<T>()envelope handling (error.forbidden, error-message matching for the unavailable case).+page.tspulls the deployment from the parent layout, mirroring logs/metrics).src/lib/server/mock.ts(synthetic issues across kinds + statuses, two-page cursor paging,sg1location simulating no log capture) sobun dev:mockrenders the tab end-to-end.Small helpers (pod-hue, relative-time, kind/severity) are kept local to the page —
$lib/deployment/logFormat.tsis deliberately not created or imported (owned by another unmerged PR), and no "view in History" deep-link is added (same reason).bun check→ 0 errors, 0 warnings.bun lint→ clean.Screenshots
Errors tab with an issue expanded (sample stack + recent occurrences + triage actions), 1320px.
🤖 Generated with Claude Code
https://claude.ai/code/session_011d4bVuGLnCbcJD9ZvastPH