Hide env and env groups for static on the GitHub page#213
Merged
Conversation
Static deployments serve a release from the edge and have no pod, so env vars and env groups don't apply (the apiserver zeroes them for static). On the GitHub workflow generator, hide the env/env-group inputs when build type is Static and omit them from the generated workflow YAML. Done by wrapping the env/env-group/pull-secret grid in a single buildType==='dockerfile' guard (folding in the existing pull-secret conditional) and gating the env/envGroups lines in withBlock(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying deploys-app--console with
|
| Latest commit: |
0bd2412
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2bb86150.deploys-app--console.pages.dev |
| Branch Preview URL: | https://github-static-hide-env.deploys-app--console.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the GitHub workflow-generator page, when build type = Static, hide the Environment variables and Env groups inputs, and omit them from the generated workflow YAML.
Why
Static deployments serve a release from the edge and have no pod, so env vars and env groups don't apply — the apiserver zeroes
Env/EnvGroupsfor static deployments. Showing the inputs (and emitting them into the workflow) is misleading and would be ignored/rejected downstream. This matches how the detail page already hides env/envGroups for static.How
{#if gen.buildType === 'dockerfile'}guard, folding in the pull-secret block's existing identical conditional (so all three container-only fields share one guard).env/envGroupslines inwithBlock()onbuildType === 'dockerfile'so they never leak into the generated YAML even if values were typed before switching to Static.workingDirectorystays (it applies to static builds too).Most of the diff is re-indentation from un-nesting the pull-secret block; the behavioral change is the two guards.
bun lintandbun checkpass clean.🤖 Generated with Claude Code