Fix deploy silent no-op after zx 7→8 upgrade#100
Merged
Conversation
Two breaking changes from the zx 7→8 upgrade caused this regression:
1. zx 8 defaults verbose to false (was true in zx 7), suppressing all
command output from the Actions log. Fix: set $.verbose = true.
2. zx 8's quote("") returns $'' (explicit empty shell argument) instead
of "" (which vanished in the command string). When the optional
recipe input is empty, this passed an unwanted empty argument to
Deployer, causing it to silently no-op. Fix: use arrays for optional
args (recipe, verbosity) so empty values produce no arguments.
Agent-Logs-Url: https://github.com/deployphp/action/sessions/9f7b96de-ce5c-4f32-baac-23aa7b69e161
Co-authored-by: antonmedv <141232+antonmedv@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
antonmedv
April 8, 2026 09:14
View session
antonmedv
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.0.25 build upgraded zx from v7 to v8, which introduced two breaking behavioral changes that caused deploys to silently succeed without running any tasks.
verbosedefault flipped tofalsezx 8 defaults
verbosetofalse(wastrue). All command output—stdout and stderr—is captured internally but never printed to the Actions log.Fix: Set
$.verbose = trueafter import.quote("")now emits an explicit empty shell argumentzx 7's
quote("")returned""(vanishes in shell). zx 8 returns$''(explicit empty positional arg). When the optionalrecipeinput is unset, the command becomes:That spurious empty argument causes Deployer (v8 especially) to silently no-op.
Fix: Use arrays instead of strings for optional args (
recipe,verbosity). Empty arrays produce no arguments in zx template literals: