Skip to content

fix(path): match backtick, not U+2018, in [[:punct:]] - #7354

Closed
tomas-zijdemans wants to merge 2 commits into
denoland:mainfrom
tomas-zijdemans:fix/path-punct-backtick
Closed

tomas-zijdemans wants to merge 2 commits into
denoland:mainfrom
tomas-zijdemans:fix/path-punct-backtick

Conversation

@tomas-zijdemans

Copy link
Copy Markdown
Contributor

[[:punct:]] in globToRegExp() matched ‘ (U+2018, left single quotation mark) where it should match the backtick. POSIX defines the class as the 32 ASCII punctuation characters, so [[:punct:]]* skipped a file named `notes and matched one named ‘notes. The test had the same typo in its expected string, which is why it passed.

This swaps that one character in the class string and in the test, and adds an assertion that ‘ doesn't match. All 91 path tests pass, and fmt and lint are clean.

I used Claude Code to help investigate and write this change.

@github-actions github-actions Bot added the path label Oct 9, 2026
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.04%. Comparing base (f834d02) to head (6acb0ac).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7354    +/-   ##
========================================
  Coverage   95.04%   95.04%            
========================================
  Files         619      618     -1     
  Lines       52012    51757   -255     
  Branches     9450     9401    -49     
========================================
- Hits        49434    49192   -242     
+ Misses       2031     2022     -9     
+ Partials      547      543     -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tomas-zijdemans
tomas-zijdemans deleted the fix/path-punct-backtick branch October 11, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant