Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7349 +/- ##
========================================
Coverage 95.04% 95.04%
========================================
Files 619 618 -1
Lines 52012 51771 -241
Branches 9450 9405 -45
========================================
- Hits 49434 49206 -228
+ Misses 2031 2022 -9
+ Partials 547 543 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dvd233
marked this pull request as ready for review
October 5, 2026 19:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject document statements that run into the next assignment or table header without a newline, such as
a = 1 b = 2and[table] a = 1.A private boundary check runs after successful document-level key/value pairs and table or array-table headers, before existing whitespace/comment skipping can lose the newline evidence. It permits LF, CRLF, EOF, and trailing comments after optional spaces or tabs. Comments remain on the existing scanner path. Reusable pair/value parsers, generic repetition, the scanner, inline tables, and multiline value parsing are unchanged.
The tests cover missing separators, valid comments and line endings, EOF, multiline values, and error positions. Removing four ignore entries enables six existing fixtures under
invalid/key/:after-array,after-table,after-value,no-eol-01,no-eol-03, andno-eol-04.This addresses one document-statement separation defect tracked by #6663. It is partial progress on that issue and does not depend on #7347 or #7348.
Validation
tomllibacceptance and normalized values after the fix. Its repeated cases exercise the same separator defect and preserved behavior.deno task okpassed in the isolated fork validation run, using the unchanged reviewed source plus a separate validation workflow: 7,504 passed (3,288 steps), 0 failed, 116 ignored.AI assistance was used for implementation, tests, review, and this PR description.