Repository navigation
A failed answer is logged with its code and message - #1189
Merged
Merged
Conversation
The error frame was the only copy: the browser saw why an answer failed and the server kept nothing, so a failure in production could only be read by asking the person to open their developer tools. One warn line per failed answer, with the conversation, the code the UI keys its wording on, and the sentence the endpoint said. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
gedaiu
force-pushed
the
fix/log-answer-failures
branch
from
October 10, 2026 20:28
96e7c44 to
d90b340
Compare
WaylandYang
approved these changes
Oct 11, 2026
WaylandYang
left a comment
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this. A failed answer left nothing in the server log, and one warn with the conversation, the code and the endpoint's message is the right size of fix. It already paid for itself in #1190. Merging now. Thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
Debugging #1183 against a production install: every failed answer reached the browser as an
errorframe and the server logged nothing about it, so the only way to learn why a chat failed was to ask the person to open developer tools and copy the frame. Ingestion failures, by contrast, are in the log.What changed
chat_generation::runlogs onewarnper failed answer: the conversation id, thecodethe UI keys its wording on, and the message. Nothing else changes; the frame is still sent as before.cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test -p utopia-serverpass (601).