Repository navigation
Show property regression cases and their source evidence in the ontology workbench. - #1184
Merged
WaylandYang merged 2 commits intoOct 10, 2026
Merged
Conversation
…gy edits against source statements. Signed-off-by: Virtue039 <virtue039@qq.com>
WaylandYang
approved these changes
Oct 10, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the second slice, and for the size note at the top: that is what the new CONTRIBUTING entry asks for. I built it on top of dev and ran it on a base migrated from rc8: the cases panel lists a match and a mismatch recorded by a real alignment run, the document viewer offers the action on open statements only and not on typed projections, and the API refuses an attribute for an entity object. Typecheck and the 268 web tests pass. One thing for a later slice, not this one: a case cannot yet say that a statement should bind to nothing, and the base I tried had exactly that (不再负责 bound to responsibleFor). Merging now. Thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Property regression cases from #1178 now record alignment comparisons, but people cannot inspect them or add an expectation while reading its source. This is the workbench slice welcomed in the merge review, following #1103 and ADR 0061 cut 2.
What changes
Review size
This is the single workbench workflow requested as the second slice of #1178. The 693 added lines include 189 test lines, 68 i18n lines and the dated ADR note. The authorized read API supplies the labels and saved results the view needs; the document action lets people record the expectation the view presents. Keeping these together delivers a usable source-to-case workflow rather than an endpoint without its consumer or a screen without its human input. The storage and alignment recording were already split out and merged in #1178.
How it was checked
arm64), Rust 1.99.0, Node 20.19.5, pnpm 10.2.1, PostgreSQL 16.15 with pgvector 0.8.7. Checked commitc3777a507c85406a91f10a024e6fc693e01cc1b7on top of upstream5229278.cargo fmt --all --checkandcargo clippy --locked --workspace --all-targets -- -D warningspass.cargo test --locked --workspace: 1,487 passed, 6 ignored, with a fresh migrated PostgreSQL/pgvector database andUTOPIA_TEST_REQUIRE_DB=1,UTOPIA_TEST_REQUIRE_PDFTOTEXT=1.pnpm install --frozen-lockfile,pnpm build,pnpm test: 268 tests pass.node --test scripts/bench/lib.test.mjs: 15 tests pass.Before review
git commit -s)cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspacepassweb/:pnpm buildandpnpm testpasscrates/utopia-store/was tested withUTOPIA_DATABASE_URLsetweb/src/i18n/en.tsandzh.tsdocs/decisions/