Repository navigation
Record the real GCS run and guard the console-folder path in its test - #1091
Merged
Merged
Conversation
… console placeholder to filter. Signed-off-by: FabianIMV <101426902+FabianIMV@users.noreply.github.com>
WaylandYang
approved these changes
Oct 6, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Exactly what was agreed on #214, and nothing extra. Two things I checked:
- Counting placeholders on the raw listing before calling
fetchis the right order:fetchdrops them by size, so its output alone could not tell a filtered bucket from an empty one. - The fixture is now written where the next person will look, so a first run no longer panics on a bare
a.txt.
CI is green; the live test stays skipped there, as intended. Merging, and I will close #214 by hand since the PR targets dev.
Thank you for the run and for following it through to a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on the live run reported in #214.
Storage Object Viewer.docs/a.txtcontaininghello, plus one folder made in the Cloud Console.a.txt, as the S3 test does.fetchreturns none, so a green run can't come from a bucket without one.Ran
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace, andit_reads_from_gcsagainst the real bucket.Closes #214