Skip to content

stake: Correct off by one in revoke create helper. #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davecgh merged 1 commit into from
Aug 27, 2026
+26 −1
Merged

stake: Correct off by one in revoke create helper. #3784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blockchain/stake/staketx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,7 +1408,7 @@ func CreateRevocationFromTicket(ticketHash *chainhash.Hash,
feeApplied := false
for i, payToHash := range payToHashes {
// Ensure amount is in the valid range for monetary amounts.
if amounts[i] <= 0 || amounts[i] > dcrutil.MaxAmount {
if amounts[i] < 0 || amounts[i] > dcrutil.MaxAmount {
str := fmt.Sprintf("invalid output amount: %v (min: 0, max: %v)",
amounts[i], dcrutil.MaxAmount)
return nil, stakeRuleError(ErrSStxBadCommitAmount, str)
Expand Down
25 changes: 25 additions & 0 deletions blockchain/stake/staketx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1522,6 +1522,23 @@ func TestCreateRevocationFromTicket(t *testing.T) {
autoRevocationsTxFee := dcrutil.Amount(0)
autoRevocationsTxVersion := TxVersionAutoRevocations

// Ticket commitment with a zero commitment amount.
ticketOutZeroCommitment := &MinimalOutput{
PkScript: hexToBytes("6a1e86c6da62556f5e21fbce3564b7374724d65f0cbb000" +
"00000000000000058"),
Value: 0,
Version: 0,
}
ticketMinOutsZeroCommitment := []*MinimalOutput{
ticketOut1,
ticketOutZeroCommitment,
ticketOut3,
ticketOut4,
ticketOut5,
}
zeroCommitmentRevocationTxHash := mustParseHash("9a2e88b9f6703e6fa941cb390" +
"34fb88a7a57714ca264309e5b79ecc6f8beec5a")

// Invalid script version.
ticketOutInvalidScriptVersion := &MinimalOutput{
PkScript: hexToBytes("6a1e86c6da62556f5e21fbce3564b7374724d65f0cbb51c66d0" +
Expand Down Expand Up @@ -1585,6 +1602,14 @@ func TestCreateRevocationFromTicket(t *testing.T) {
revocationTxVersion: revocationTxVersion,
prevHeaderBytes: prevHeaderBytes,
wantTxHash: *revocationHash,
}, {
name: "valid with zero commitment amount",
ticketHash: ticketHash,
ticketMinOuts: ticketMinOutsZeroCommitment,
revocationTxFee: revocationTxFee,
revocationTxVersion: revocationTxVersion,
prevHeaderBytes: prevHeaderBytes,
wantTxHash: *zeroCommitmentRevocationTxHash,
}, {
name: "valid with P2SH and P2PKH outputs (auto revocations " +
"enabled",
Expand Down