mixclient: Override timeout and jitter for testing - #3781
Draft
jholdstock wants to merge 1 commit into
Draft
Conversation
This reduces the total runtime for the mixclient package tests from ~975s to ~39s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the total runtime for the mixclient package tests from ~975s to ~39s.
This is an alternative to #3732, demonstrating that the runtime can still be dramatically reduced regardless of the introduction of DCRS phase.
While this solution has a nice benefit of not needing changes in wallet, I still prefer the parameter solution rather than overriding package variables. Perhaps the ideal option is to make all of the timeout and jitter durations parameters?