Repository navigation
Fail lmlite-models when a model has no ONNX weights - #14
Merged
Merged
Conversation
lmlite-models exited 0 and listed a model in manifest.json even when none of its ONNX weights were copied: missing weights, or symlinks, which model_files() skipped without a warning. The browser then loaded the model from the site only and failed at run time. model_files() now copies symlinks that point to files inside the model directory, skips and names the others, and raises when a model has no ONNX weights. This applies to both --format files and --format zip.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 82.96% 83.05% +0.08%
==========================================
Files 8 8
Lines 2472 2478 +6
==========================================
+ Hits 2051 2058 +7
+ Misses 421 420 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lmlite-models exited 0 and listed a model in manifest.json even when none of its ONNX weights were copied: missing weights, or symlinks, which model_files() skipped without a warning. The browser then loaded the model from the site only and failed at run time.
model_files() now copies symlinks that point to files inside the model directory, skips and names the others, and raises when a model has no ONNX weights. This applies to both --format files and --format zip.