Skip to content

fix(OpenStack):setting compute api version via config#977

Open
dweinholz wants to merge 15 commits into
devfrom
fix/compute_api_version
Open

fix(OpenStack):setting compute api version via config#977
dweinholz wants to merge 15 commits into
devfrom
fix/compute_api_version

Conversation

@dweinholz

@dweinholz dweinholz commented May 27, 2026

Copy link
Copy Markdown
Contributor

Provide compuite API version via config

#974

Also the Branch https://github.com/deNBI/simplevm-portal/tree/feat/compute_api_version should be merged but currently github shows an eror when trying to create a PR

Try to fulfill the following points before the Pull Request is merged:

  • Give a meaningfull description for the PR
  • The PR is reviewed by one of the team members.
  • If a linting PR exists, it must be merged before this PR is allowed to be merged.
  • It must be checked if anything in the Readme must be adjusted (development-, production-, setup).
  • If the requirements.txt have changed, check if the patches still work
  • It must be checked if any section in the wiki (https://simplevm.denbi.de/wiki/) should be adjusted.
  • If the PR is merged in the master then a release should be be made.
  • If the new code is readable, if not it should be well commented

For any changes of the code please consider:

  • Cover the changes with corresponding unit tests

For releases only:

  • If the review of this PR is approved and the PR is followed by a release then the .env file
    in the cloud-portal repo should also be updated.
  • If you are making a release then please sum up the changes since the last release on the release page using the clog tool with clog -F

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Coverage

Coverage Report
FileStmtsMissCoverMissing
simple_vm_client
   VirtualMachineHandler.py2242121 91%
   __init__.py10100% 
simple_vm_client/benchmark
   __init__.py00100% 
   test_service.py523636 31%
simple_vm_client/bibigrid_connector
   __init__.py00100% 
   bibigrid_connector.py1353636 73%
   test_bibigrid_connector.py1190100% 
simple_vm_client/flavor_resource_exporter_connector
   __init__.py20100% 
   flavor_resource_exporter_connector.py1311717 87%
   test_flavor_resource_exporter_connector.py2420100% 
simple_vm_client/forc_connector
   __init__.py00100% 
   forc_connector.py3252828 91%
simple_vm_client/forc_connector/playbook
   __init__.py00100% 
   playbook.py1890100% 
   test_playbook.py3810100% 
simple_vm_client/forc_connector/template
   __init__.py00100% 
   template.py2291414 94%
simple_vm_client/metadata_connector
   metadata_connector.py1122626 77%
   test_metadata_connector.py680100% 
simple_vm_client/openstack_connector
   __init__.py00100% 
   openstack_connector.py1161220220 81%
   test_openstack_connector.py129022 99%
simple_vm_client/tests
   test_virtualmachinehandler.py3250100% 
simple_vm_client/util
   __init__.py00100% 
   state_enums.py700100% 
   test_thrift_converter.py1700100% 
   thrift_converter.py8033 96%
TOTAL530640392% 

Tests Skipped Failures Errors Time
339 0 💤 0 ❌ 0 🔥 6.876s ⏱️

@dweinholz dweinholz requested a review from qqmok June 22, 2026 07:53
@dweinholz dweinholz assigned qqmok and unassigned vktrrdk Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants