Repository navigation
fix(engine): apply preferences during active analysis - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preferences can now be edited during analysis and take effect after a brief stop and restart. Refs #121.
The old search must acknowledge
stopwithbestmovebefore receiving new options or a position. Settings and position changes made during that wait coalesce to their latest values. Pressing Stop prevents the restart while still applying pending preferences; engine termination prevents further starts. The same transition handles existing MultiPV and WDL changes, whose separate callbacks could otherwise restart an obsolete position.Tests hold the external UCI process at the stop acknowledgement to check command order and cancellation. They also open the real Preferences window during analysis. The full ASan/UBSan suite and Release build passed; a real Stockfish process was exercised through preference changes, restarts, terminal positions, and termination.