Change ruled lines to not be affected by DECLRMM#545
Merged
Conversation
Previously ruled lines between the left and right margins would scroll in the same way as text between those margins. While this was inconsistent with DECterm I considered this OK as DECterm didn't support DECLRMM anyway. But WRQ Reflection *does* support DECLRMM and it also doesn't scroll ruled lines between the left and right margins. It was also pointed out that none of the other features of the Horizontal Scrolling extension affect ruled lines, so this was perhaps an intentional choice on the part of WRQ. So this change makes K95s behaviour consistent with all other terminals implementing this feature, reducing the chances of any surprising behaviour now and in the future.
Switch to a mirror.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously ruled lines between the left and right margins would scroll in the same way as text between those margins. While this was inconsistent with DECterm I considered this OK at the time as DECterm didn't support DECLRMM anyway.
But WRQ Reflection does support DECLRMM and it also doesn't scroll ruled lines between the left and right margins. It was also pointed out that none of the other features of the Horizontal Scrolling extension affect ruled lines, so this was perhaps an intentional choice on the part of WRQ.
So this change makes K95s behaviour consistent with all other terminals implementing this feature, reducing the chances of any surprising behaviour now and in the future.