Use an updated version of ConPTY#540
Merged
Merged
Conversation
Try to load conpty.dll from the executable directory first, then from the path, before trying to use the version thats built-in to kernel32.dll. This allows K95 to run programs like vtnibbler properly in a PTY.
Versions of K95 that can run on more than one CPU architecture need to ship with variants of OpenConsole.exe for each CPU architecture they can run on. These need to go into \$ARCH\OpenConsole.exe, and conpty.dll will pick up the right variant from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to load conpty.dll from the executable directory first, then from the path. If conpty.dll can't be found then fall back to the older ConPTY implementation in kernel32.dll.
This seems to be enough to get, eg, vtnibbler working properly in 64bit builds of K95, but the 32bit builds don't seem to work with 32bit builds of conpty for some reason.
TODO: